Build with .NET 10 successfully by jonathanpeppers · Pull Request #27103 · dotnet/maui

jonathanpeppers · 2025-01-13T16:48:42Z

Changes required:

Get appropriate net9 branded workload manifests from dotnet/runtime
Fix NuGet package downgrades:

    src\SingleProject\Resizetizer\src\Resizetizer.csproj : error NU1605:
      Warning As Error: Detected package downgrade: System.Runtime.CompilerServices.Unsafe from 6.1.0 to 6.0.0. Reference the package directly from the project to select a different version.
       Microsoft.Maui.Resizetizer -> Microsoft.Bcl.AsyncInterfaces 10.0.0-alpha.1.25058.4 -> System.Threading.Tasks.Extensions 4.6.0 -> System.Runtime.CompilerServices.Unsafe (>= 6.1.0)
       Microsoft.Maui.Resizetizer -> System.Runtime.CompilerServices.Unsafe (>= 6.0.0)
    src\Core\src\Core.csproj : error NU1605:
      Warning As Error: Detected package downgrade: System.Numerics.Vectors from 4.6.0 to 4.5.0. Reference the package directly from the project to select a different version.
       Microsoft.Maui.Core -> Microsoft.Extensions.Logging.Abstractions 10.0.0-alpha.1.25057.17 -> System.Memory 4.6.0 -> System.Numerics.Vectors (>= 4.6.0)
       Microsoft.Maui.Core -> System.Numerics.Vectors (>= 4.5.0)

Update to iOS, tvOS, MacCatalyst 18.2

    10.0.100-alpha.1.25059.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(259,5):
    error NETSDK1140:
        18.0 is not a valid TargetPlatformVersion for MacCatalyst. Valid versions include:
        18.2
    10.0.100-alpha.1.25059.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(259,5):
    error NETSDK1140:
        18.0 is not a valid TargetPlatformVersion for iOS. Valid versions include:
        18.2

Temporarily ignore CS9270:
- Mark interceptors feature as stable and deprecate file path based attributes roslyn#76312
- Add public API to obtain a location specifier for a call roslyn#72133

    artifacts\obj\Controls.Core\Debug\net10.0\Microsoft.Maui.Controls.BindingSourceGen\Microsoft.Maui.Controls.BindingSourceGen.BindingSourceGenerator\D--src-maui-src-Controls-src-Core-BindableLayout-BindableLayout.cs-GeneratedBindingInterceptors-235-10.g.cs(43,4): error CS9270: 'InterceptsLocationAttribute(string, int, int)' is not supported. Move to 'InterceptableLocation'-based generation of these attributes instead. (https://github.com/dotnet/roslyn/issues/72133)
    artifacts\obj\Controls.Core\Debug\net10.0\Microsoft.Maui.Controls.BindingSourceGen\Microsoft.Maui.Controls.BindingSourceGen.BindingSourceGenerator\D--src-maui-src-Controls-src-Core-ContentConverter.cs-GeneratedBindingInterceptors-72-13.g.cs(43,4): error CS9270: 'InterceptsLocationAttribute(string, int, int)' is not supported. Move to 'InterceptableLocation'-based generation of these attributes instead. (https://github.com/dotnet/roslyn/issues/72133)
    artifacts\obj\Controls.Core\Debug\net10.0\Microsoft.Maui.Controls.BindingSourceGen\Microsoft.Maui.Controls.BindingSourceGen.BindingSourceGenerator\D--src-maui-src-Controls-src-Core-ContentConverter.cs-GeneratedBindingInterceptors-77-13.g.cs(43,4): error CS9270: 'InterceptsLocationAttribute(string, int, int)' is not supported. Move to 'InterceptableLocation'-based generation of these attributes instead. (https://github.com/dotnet/roslyn/issues/72133)

iOS API changes:

    error CS0618: 'CLLocation.AccurracyBestForNavigation' is obsolete: 'Use 'AccuracyBestForNavigation' instead.'

    Screenshot.ios.cs(57,69): error CS8602: Dereference of a possibly null reference.

    Platform\iOS\KeyboardAutoManagerScroll.cs(867,55): error CS8602: Dereference of a possibly null reference.

    src\Core\src\Platform\iOS\MauiSwipeView.cs(601,8): error CS8625: Cannot convert null literal to non-nullable reference type.
    src\Core\src\Platform\iOS\MauiSwipeView.cs(634,8): error CS8625: Cannot convert null literal to non-nullable reference type.

    ResignFirstResponderTouchGestureRecognizer.iOS.cs(70,12): error CS8600: Converting null literal or possible null value to non-nullable type.

    GesturePlatformManager.iOS.cs(282,21): error CS8602: Dereference of a possibly null reference.

Most notably:

UIView.Window can be null.
Typo in API fixed AccurracyBestForNavigation -> AccuracyBestForNavigation
Ignore warnings related with trimming
IL2026; IL2067;IL2072 ;IL2075;IL2087; IL2091;
Move to Xcode 16.2

Changes required: * Get appropriate `net9` branded workload manifests from dotnet/runtime * Fix NuGet package downgrades: src\SingleProject\Resizetizer\src\Resizetizer.csproj : error NU1605: Warning As Error: Detected package downgrade: System.Runtime.CompilerServices.Unsafe from 6.1.0 to 6.0.0. Reference the package directly from the project to select a different version. Microsoft.Maui.Resizetizer -> Microsoft.Bcl.AsyncInterfaces 10.0.0-alpha.1.25058.4 -> System.Threading.Tasks.Extensions 4.6.0 -> System.Runtime.CompilerServices.Unsafe (>= 6.1.0) Microsoft.Maui.Resizetizer -> System.Runtime.CompilerServices.Unsafe (>= 6.0.0) src\Core\src\Core.csproj : error NU1605: Warning As Error: Detected package downgrade: System.Numerics.Vectors from 4.6.0 to 4.5.0. Reference the package directly from the project to select a different version. Microsoft.Maui.Core -> Microsoft.Extensions.Logging.Abstractions 10.0.0-alpha.1.25057.17 -> System.Memory 4.6.0 -> System.Numerics.Vectors (>= 4.6.0) Microsoft.Maui.Core -> System.Numerics.Vectors (>= 4.5.0) * Update to iOS, tvOS, MacCatalyst 18.2 10.0.100-alpha.1.25059.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(259,5): error NETSDK1140: 18.0 is not a valid TargetPlatformVersion for MacCatalyst. Valid versions include: 18.2 10.0.100-alpha.1.25059.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(259,5): error NETSDK1140: 18.0 is not a valid TargetPlatformVersion for iOS. Valid versions include: 18.2 * Temporarily ignore `CS9270`: * dotnet/roslyn#76312 * dotnet/roslyn#72133 artifacts\obj\Controls.Core\Debug\net10.0\Microsoft.Maui.Controls.BindingSourceGen\Microsoft.Maui.Controls.BindingSourceGen.BindingSourceGenerator\D--src-maui-src-Controls-src-Core-BindableLayout-BindableLayout.cs-GeneratedBindingInterceptors-235-10.g.cs(43,4): error CS9270: 'InterceptsLocationAttribute(string, int, int)' is not supported. Move to 'InterceptableLocation'-based generation of these attributes instead. (dotnet/roslyn#72133) artifacts\obj\Controls.Core\Debug\net10.0\Microsoft.Maui.Controls.BindingSourceGen\Microsoft.Maui.Controls.BindingSourceGen.BindingSourceGenerator\D--src-maui-src-Controls-src-Core-ContentConverter.cs-GeneratedBindingInterceptors-72-13.g.cs(43,4): error CS9270: 'InterceptsLocationAttribute(string, int, int)' is not supported. Move to 'InterceptableLocation'-based generation of these attributes instead. (dotnet/roslyn#72133) artifacts\obj\Controls.Core\Debug\net10.0\Microsoft.Maui.Controls.BindingSourceGen\Microsoft.Maui.Controls.BindingSourceGen.BindingSourceGenerator\D--src-maui-src-Controls-src-Core-ContentConverter.cs-GeneratedBindingInterceptors-77-13.g.cs(43,4): error CS9270: 'InterceptsLocationAttribute(string, int, int)' is not supported. Move to 'InterceptableLocation'-based generation of these attributes instead. (dotnet/roslyn#72133) * iOS API changes: error CS0618: 'CLLocation.AccurracyBestForNavigation' is obsolete: 'Use 'AccuracyBestForNavigation' instead.' Screenshot.ios.cs(57,69): error CS8602: Dereference of a possibly null reference. Platform\iOS\KeyboardAutoManagerScroll.cs(867,55): error CS8602: Dereference of a possibly null reference. src\Core\src\Platform\iOS\MauiSwipeView.cs(601,8): error CS8625: Cannot convert null literal to non-nullable reference type. src\Core\src\Platform\iOS\MauiSwipeView.cs(634,8): error CS8625: Cannot convert null literal to non-nullable reference type. ResignFirstResponderTouchGestureRecognizer.iOS.cs(70,12): error CS8600: Converting null literal or possible null value to non-nullable type. GesturePlatformManager.iOS.cs(282,21): error CS8602: Dereference of a possibly null reference. Most notably: * `UIView.Window` can be null. * Typo in API fixed `AccurracyBestForNavigation` -> `AccuracyBestForNavigation`

Copilot

Copilot reviewed 5 out of 15 changed files in this pull request and generated no comments.

Files not reviewed (10)

Directory.Build.props: Language not supported
Directory.Build.targets: Language not supported
eng/Versions.props: Language not supported
src/DotNet/Dependencies/Workloads.csproj: Language not supported
src/Essentials/src/Compass/Compass.ios.cs: Evaluated as low risk
src/Core/src/Platform/iOS/MauiSwipeView.cs: Evaluated as low risk
eng/pipelines/ui-tests.yml: Evaluated as low risk
src/Controls/src/Core/Platform/GestureManager/GesturePlatformManager.iOS.cs: Evaluated as low risk
eng/pipelines/device-tests.yml: Evaluated as low risk
src/Core/src/Platform/iOS/KeyboardAutoManagerScroll.cs: Evaluated as low risk

Comments suppressed due to low confidence (2)

src/Controls/src/Core/ContentPage/HideSoftInputOnTappedChanged/ResignFirstResponderTouchGestureRecognizer.iOS.cs:70

The forced non-null assertion 'view.Superview!' should be verified to ensure that 'Superview' is indeed never null in this context.

view = view.Superview!;

src/Essentials/src/Geolocation/GeolocationAccuracyExtensionMethods.ios.macos.cs:22

The typo in CLLocation.AccurracyBestForNavigation has been corrected to CLLocation.AccuracyBestForNavigation.

return CLLocation.AccuracyBestForNavigation;

Testing: dotnet/maui#27103

Workaround: dotnet/android@715a36a

D:\src\maui\src\TestUtils\src\TestShared\xUnitSharedAttributes.cs(75,89): error CS0117: 'DynamicallyAccessedMemberTypes' does not contain a definition for 'PublicParameterlessConstructors' D:\src\maui\src\TestUtils\src\TestShared\xUnitSharedAttributes.cs(83,63): error CS0117: 'DynamicallyAccessedMemberTypes' does not contain a definition for 'PublicParameterlessConstructors'

src/TestUtils/src/DeviceTests.Runners.SourceGen/RunnerGenerator.cs

This reverts commit 882c45e.

Context: dotnet/macios#21351 This will avoid some of the fallout of the above PR.

…g is gone

Fixes? [15:12:46.2484560] 2025-01-22 15:12:46.242709-0800 RunOniOSmauiRel1586373188[97228:54445246] Received unhandled Objective-C exception that was marshalled from a managed exception: A suitable constructor for type 'Microsoft.Maui.Hosting.FontsMauiAppBuilderExtensions+FontInitializer' could not be located. Ensure the type is concrete and services are registered for all parameters of a public constructor. (System.InvalidOperationException) [15:12:46.2484780] at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.CreateConstructorCallSite(ResultCache, ServiceIdentifier, Type, CallSiteChain) + 0x4de [15:12:46.2485210] at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.TryCreateExact(ServiceDescriptor, ServiceIdentifier, CallSiteChain, Int32) + 0x1a5 [15:12:46.2485640] at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.TryCreateEnumerable(ServiceIdentifier, CallSiteChain) + 0x42f [15:12:46.2485930] at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.CreateCallSite(ServiceIdentifier serviceIdentifier, CallSiteChain callSiteChain) + 0xfb [15:12:46.2486100] at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.GetCallSite(ServiceIdentifier, CallSiteChain) + 0x92 [15:12:46.2486220] at Microsoft.Extensions.DependencyInjection.ServiceProvider.CreateServiceAccessor(ServiceIdentifier serviceIdentifier) + 0x68 [15:12:46.2486330] at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey, Func`2) + 0xdc [15:12:46.2486790] at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier, ServiceProviderEngineScope) + 0x39 [15:12:46.2486900] at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider, Type) + 0x3d [15:12:46.2487000] at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider) + 0x2f [15:12:46.2487100] at Microsoft.Maui.MauiContextExtensions.InitializeAppServices(MauiApp) + 0x1b [15:12:46.2487190] at Microsoft.Maui.Hosting.MauiAppBuilder.Build() + 0x67 [15:12:46.2487420] at Microsoft.Maui.MauiUIApplicationDelegate.WillFinishLaunching(UIApplication application, NSDictionary launchOptions) + 0x44 [15:12:46.2487530] at RunOniOSmauiRel1586373188!<BaseAddress>+0xe200a

This reverts commit 802e4c1.

This reverts commit 6b8e48a.

This reverts commit b0e0e45.

Copilot AI review requested due to automatic review settings January 13, 2025 16:48

jonathanpeppers requested a review from a team as a code owner January 13, 2025 16:48

jonathanpeppers requested review from jfversluis and jsuarezruiz and removed request for a team January 13, 2025 16:48

Merge branch 'net10.0' into dev/peppers/net10.0

f7349f3

Copilot AI reviewed Jan 13, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

jonathanpeppers added 2 commits January 13, 2025 11:27

Disable tizen net10.0 temporarily

2e2d7ca

TargetFramework=net10.0

80b9b1a

jonathanpeppers added a commit to dotnet/android that referenced this pull request Jan 13, 2025

REVERT ME

e7069c4

Testing: dotnet/maui#27103

jonathanpeppers added 10 commits January 13, 2025 12:17

TargetFramework=net10.0

ef39613

Unused yaml: TestTargetFrameworks

0e255a0

Update RunnerGenerator.cs

0f43f7d

Workaround: dotnet/android@715a36a

Put iOS simulator versions back to 18.0

bed3a19

Update RunnerGenerator.cs

9f6d36d

Update Core.DeviceTests.Shared.csproj

23778ed

Update RunnerGenerator.cs

b9f32f6

Remove Tizen project

cd3d894

Update ios.cake

27b1392

jonathanpeppers commented Jan 13, 2025

View reviewed changes

src/TestUtils/src/DeviceTests.Runners.SourceGen/RunnerGenerator.cs Outdated Show resolved Hide resolved

jonathanpeppers and others added 4 commits January 13, 2025 15:25

Update Core.DeviceTests.csproj

1b19257

Update android

7a93f41

Update xcode

1328e29

Disable trimming warnings for now

2557581

jonathanpeppers and others added 15 commits January 22, 2025 09:54

Revert "Update MacTemplateTest.cs"

5f66e8b

This reverts commit 882c45e.

EnableTrimAnalyzer=false for default projects

41951f1

Context: dotnet/macios#21351 This will avoid some of the fallout of the above PR.

$(EnableTrimAnalyzer) take 2

76d1c31

Update TestUtils.DeviceTests.Sample.csproj

eaa331a

Update Microsoft.Maui.Controls.Common.targets

c7b947e

Update Microsoft.Maui.Controls.Common.targets

fb47361

Update SimpleTemplateTest.cs

bb61774

Update Microsoft.Maui.Controls.Common.targets

dcc9416

System.Text.Json.Serialization.Converters.EnumConverterFactory warnin…

77c47dc

…g is gone

Merge branch 'net10.0' into dev/peppers/net10.0

85292b3

Merge branch 'net10.0' into dev/peppers/net10.0

b0d1a03

Revert "Potential fix for M.E.DI failure"

8a9cc61

This reverts commit 802e4c1.

Update versions with CoherentParentDependency

b51bce5

Update versions with coherent Microsoft.JSInterop

deb3a7f

rmarinho mentioned this pull request Jan 23, 2025

[net11.0] Enable or remove tizen from the repo #27301

Open

jonathanpeppers added 6 commits January 23, 2025 08:50

Use strongly-typed Transient() for M.E.DI

b0e0e45

MauiVersionCurrent / MauiVersionPrevious

fa6451e

Update FontsMauiAppBuilderExtensions.cs

6b8e48a

Revert "Update FontsMauiAppBuilderExtensions.cs"

45e857c

This reverts commit 6b8e48a.

Revert "Use strongly-typed Transient() for M.E.DI"

27db906

This reverts commit b0e0e45.

Comment a few NativeAOT tests

0ef6143

This was referenced Jan 23, 2025

[net10.0] Enable warnings for CS9270 #27315

Closed

[net10.0] Enable trimmer warnings #27316

Closed

[net10.0] Check usage of mobile-librarybuilder-net9 #27318

Closed

rmarinho approved these changes Jan 23, 2025

View reviewed changes

rmarinho merged commit 76c6f1a into net10.0 Jan 23, 2025
36 of 65 checks passed

rmarinho deleted the dev/peppers/net10.0 branch January 23, 2025 20:11

simonrozsival mentioned this pull request Jan 28, 2025

[net10.0] Aggressive attribute trimming breaks NativeAOT builds dotnet/macios#22065

Closed

github-actions bot locked and limited conversation to collaborators Feb 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build with .NET 10 successfully#27103

Build with .NET 10 successfully#27103
rmarinho merged 82 commits intonet10.0from
dev/peppers/net10.0

jonathanpeppers commented Jan 13, 2025 •

edited by rmarinho

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jonathanpeppers commented Jan 13, 2025 • edited by rmarinho Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonathanpeppers commented Jan 13, 2025 •

edited by rmarinho

Loading