[iOS] PullToRefresh activity indicator improvements - fix by kubaflo · Pull Request #20824 · dotnet/maui

kubaflo · 2024-02-24T15:41:15Z

Issues Fixed

Fixes #20723
Fixes #24960

Before	After
bug.mp4	fixed.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-15.at.11.33.09.mp4	Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-15.at.11.28.24.mp4

The same issue happens with CV2
#20824 (comment)

<Grid RowDefinitions="*">
    <RefreshView IsRefreshing="False">
        <CollectionView>
            <CollectionView.Header>
                <ContentView HeightRequest="200"
                                BackgroundColor="Green"/>
            </CollectionView.Header>
            <CollectionView.ItemsSource>
                <x:Array Type="{x:Type x:String}">
                    <x:String>Item 1</x:String>
                    <x:String>Item 2</x:String>
                    <x:String>Item 3</x:String>
                </x:Array>
            </CollectionView.ItemsSource>
        </CollectionView>
    </RefreshView>
</Grid>

ghost · 2024-02-24T15:41:21Z

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz · 2024-02-26T12:30:59Z

src/Controls/tests/UITests/Tests/Issues/Issue20723.cs

+			await Task.Delay(500);
+
+			//The test passes if the activity indicator is above the header
+			VerifyScreenshot();


ValidateScreenshot will compare the screenshots pixel by pixel. Taking into account the animation of the position of the loading indicator as well as the rotation of the indicator itself, I would say that it would be better to create a device test to validate that it is within a range as well as the size.

You're right this test will probably fail in most of the cases. However, I'm not sure if the device test will be useful in this case. Maybe we should just not write a test for this issue?

Yeah, i think in this case have sense a tests checking Frames etc. Take a look to the GetRect extension method used in UITests. Let me know if need help with something.

The snapshot, with the loading indicator is not a valid option.

Also, can bind the status to a Label, and check in the test the text value Example: "Loading", "Not Loading".

I'm not sure how to get frames of this indicator in any other way than using XPath

jsuarezruiz · 2024-03-21T10:27:24Z

/azp run MAUI-UITests-public

azure-pipelines · 2024-03-21T10:27:35Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2024-05-10T10:24:17Z

/azp run

azure-pipelines · 2024-05-10T10:24:38Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-06-13T07:13:17Z

/azp run

azure-pipelines · 2024-06-13T07:13:36Z

Azure Pipelines successfully started running 3 pipeline(s).

taenito · 2024-09-19T05:46:36Z

Any news on this bug? This is one of the latest bugs preventing us from publishing our application.

metalium84 · 2024-09-20T07:58:18Z

Same for me... is there a timeline to finally fix this bug?

kubaflo · 2024-09-20T12:24:37Z

Here we go again lol. Hi, @metalium84 @taenito The MAUI team's priorities are not up to me, but you can have this fix in your app by following this @jfversluis's video if it is a major blocker for your migration https://www.youtube.com/watch?v=B2FOBjZKm9k&t=301s&pp=ygUWZ2VyYWxkIG1hdWkgcHIgdGVzdGluZw%3D%3D

azure-pipelines · 2024-09-20T17:34:39Z

Azure Pipelines successfully started running 3 pipeline(s).

jfversluis · 2024-09-20T17:34:58Z

Here we go again lol. Hi, @metalium84 @taenito The MAUI team's priorities are not up to me, but you can have this fix in your app by following this @jfversluis's video if it is a major blocker for your migration https://www.youtube.com/watch?v=B2FOBjZKm9k&t=301s&pp=ygUWZ2VyYWxkIG1hdWkgcHIgdGVzdGluZw%3D%3D

If you do test this out and let us know if this works for you that will give us more confidence that this is a right fix and we can merge it sooner. So please let us know, thanks!

taenito · 2024-09-26T09:17:36Z

I tested the branch and the loader is no longer hidden behind the header.

We still have a lot of bugs with the RefreshView on iOS (I will open news issues) but for me, this MR works well for the given issue.

kubaflo · 2024-09-27T18:25:36Z

@taenito cool! Thanks for confirming it!

kubaflo · 2024-10-15T09:45:54Z

Hi, @taenito I've also added a commit that fixes your second issue #24960

jsuarezruiz · 2024-11-15T09:17:56Z

/rebase

jsuarezruiz · 2024-11-15T09:22:34Z

/azp run

azure-pipelines · 2024-11-15T09:22:53Z

Azure Pipelines successfully started running 3 pipeline(s).

kubaflo · 2025-03-08T01:58:40Z

This PR solves the same issue with CV2:

Screen.Recording.2025-03-08.at.02.56.37.mov

mattyjjpearce · 2025-05-01T08:53:36Z

Hi - any update on this fix. Still not been reviewed by the looks of it?

* [iOS] Fixed hidden indicator * [iOS] Fixed hidden indicator

kubaflo requested a review from a team as a code owner February 24, 2024 15:41

kubaflo requested review from jsuarezruiz and tj-devel709 February 24, 2024 15:41

ghost added the community ✨ Community Contribution label Feb 24, 2024

jsuarezruiz added platform/ios area-controls-refreshview RefreshView labels Feb 26, 2024

ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Feb 26, 2024

jsuarezruiz reviewed Feb 26, 2024

View reviewed changes

Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024

dotnet deleted a comment from azure-pipelines bot Jun 13, 2024

kubaflo force-pushed the ios-hidden-activity-indicator-fix branch from 5ebde61 to d17ded2 Compare July 20, 2024 00:30

kubaflo force-pushed the ios-hidden-activity-indicator-fix branch from d17ded2 to 70d4639 Compare September 20, 2024 12:20

kubaflo changed the title ~~[iOS] PullToRefresh activity indicator hidden behind header in CollectionView - fix~~ [iOS] PullToRefresh activity indicator improvements - fix Oct 15, 2024

kubaflo force-pushed the ios-hidden-activity-indicator-fix branch from 70d4639 to fa05236 Compare October 15, 2024 09:45

dotnet deleted a comment from azure-pipelines bot Nov 15, 2024

github-actions bot force-pushed the ios-hidden-activity-indicator-fix branch from fa05236 to 7909d39 Compare November 15, 2024 09:18

kubaflo added 2 commits March 8, 2025 02:33

[iOS] Fixed hidden indicator

e121f8b

[iOS] Fixed hidden indicator

2ef173c

kubaflo force-pushed the ios-hidden-activity-indicator-fix branch from 7909d39 to 2ef173c Compare March 8, 2025 01:53

kubaflo added area-controls-collectionview CollectionView, CarouselView, IndicatorView collectionview-cv2 labels Mar 8, 2025

kubaflo self-assigned this Mar 8, 2025

PureWeen added this to the .NET 9 SR11 milestone Aug 4, 2025

PureWeen added this to MAUI SDK Ongoing Aug 4, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Aug 4, 2025

PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Aug 4, 2025

jfversluis approved these changes Aug 11, 2025

View reviewed changes

github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Aug 11, 2025

jfversluis changed the base branch from main to inflight/current August 11, 2025 08:01

jfversluis merged commit 7bf0d26 into dotnet:inflight/current Aug 11, 2025
1 check passed

github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Aug 11, 2025

github-actions bot pushed a commit that referenced this pull request Aug 11, 2025

[iOS] PullToRefresh activity indicator improvements - fix (#20824)

dddcc6e

* [iOS] Fixed hidden indicator * [iOS] Fixed hidden indicator

github-actions bot pushed a commit that referenced this pull request Aug 15, 2025

[iOS] PullToRefresh activity indicator improvements - fix (#20824)

b832c53

* [iOS] Fixed hidden indicator * [iOS] Fixed hidden indicator

github-actions bot pushed a commit that referenced this pull request Aug 15, 2025

[iOS] PullToRefresh activity indicator improvements - fix (#20824)

c70347c

* [iOS] Fixed hidden indicator * [iOS] Fixed hidden indicator

github-actions bot pushed a commit that referenced this pull request Aug 19, 2025

[iOS] PullToRefresh activity indicator improvements - fix (#20824)

396fc3f

* [iOS] Fixed hidden indicator * [iOS] Fixed hidden indicator

github-actions bot pushed a commit that referenced this pull request Aug 22, 2025

[iOS] PullToRefresh activity indicator improvements - fix (#20824)

27a6e20

* [iOS] Fixed hidden indicator * [iOS] Fixed hidden indicator

github-actions bot locked and limited conversation to collaborators Sep 10, 2025

Conversation

kubaflo commented Feb 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues Fixed

Uh oh!

ghost commented Feb 24, 2024

Uh oh!

jsuarezruiz Feb 26, 2024

Choose a reason for hiding this comment

Uh oh!

kubaflo Feb 27, 2024

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

kubaflo Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Mar 21, 2024

Uh oh!

azure-pipelines bot commented Mar 21, 2024

Uh oh!

jsuarezruiz commented May 10, 2024

Uh oh!

azure-pipelines bot commented May 10, 2024

Uh oh!

jsuarezruiz commented Jun 13, 2024 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Jun 13, 2024

Uh oh!

taenito commented Sep 19, 2024

Uh oh!

metalium84 commented Sep 20, 2024

Uh oh!

kubaflo commented Sep 20, 2024

Uh oh!

azure-pipelines bot commented Sep 20, 2024

Uh oh!

jfversluis commented Sep 20, 2024

Uh oh!

taenito commented Sep 26, 2024

Uh oh!

kubaflo commented Sep 27, 2024

Uh oh!

kubaflo commented Oct 15, 2024

Uh oh!

jsuarezruiz commented Nov 15, 2024

Uh oh!

jsuarezruiz commented Nov 15, 2024

Uh oh!

azure-pipelines bot commented Nov 15, 2024

Uh oh!

kubaflo commented Mar 8, 2025

Uh oh!

mattyjjpearce commented May 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kubaflo commented Feb 24, 2024 •

edited

Loading

jsuarezruiz commented Jun 13, 2024 •

edited by jfversluis

Loading