Implemented ios:Slider.UpdateOnTap#20124
Conversation
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
left a comment
There was a problem hiding this comment.
Could you include a sample to allow check/test the platform specific here: https://github.com/dotnet/maui/tree/main/src/Controls/samples/Controls.Sample/Pages/PlatformSpecifics/iOS?
|
@jsuarezruiz sure I will do it later today |
|
@jsuarezruiz the sample page has already been in the code https://github.com/dotnet/maui/blob/main/src/Controls/samples/Controls.Sample/Pages/PlatformSpecifics/iOS/iOSSliderUpdateOnTapPage.xaml |
640aaf4 to
b842bc7
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
This seems a bit wonky when using a centered Slider and a fixed width, I'm getting negative values that are being set. Perhaps something is still missing compared to Xamarin? |
|
@Yves-Be you're absolutely right! Thank you yot pointing it out! |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
4175ce8 to
5a0e65a
Compare
|
/rebase |
941a538 to
6caf573
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
729d081 to
e972161
Compare
Added a device test Fixes Fixed a memory leak Don't interfere with other gestures
Added a device test Fixes Fixed a memory leak Don't interfere with other gestures
Description of Change
I implemented the ios:Slider.UpdateOnTap property in the same way it has been implemented in Xamarin Forms
Issues Fixed
Fixes #20098
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-01-24.at.01.02.02.mp4