Conversation
Contributor
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
hartez
approved these changes
May 9, 2023
rmarinho
pushed a commit
that referenced
this pull request
May 30, 2023
…14905) * Changes updating Android ImageButton Padding * Updated tests * Auto-format source code --------- Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com>
Vetle444
added a commit
to DIPSAS/DIPS.Mobile.UI
that referenced
this pull request
Jul 3, 2023
[Android] dui:ImageButton now fixes padding issue: dotnet/maui#14905
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Changes updating Android ImageButton Padding to avoid sizing issues.
Before
Notice the external padding/border issue in addition to the sizing problems.
After
To validate the changes use the new sample added to the ImageButton page in the .NET MAUI Gallery.
Issues Fixed
Fixes #7927
Fixes #13101