[Windows] fixing window glitches while moving or resizing by salarcode · Pull Request #14861 · dotnet/maui

salarcode · 2023-05-01T14:07:10Z

Description of Change

IWindow.FrameChanged is a hot path and is being called many times while a window is moved or resized.
The number of calls sky rockets when dpi is being changed as the window is being moved to a different monitor with different scalling.
While the method tries to update IWindow bindable properties it causes a chain of updates that cycles back to itself and then updates the window again.

This fix tries to prevent this cycle and delay/separate the bindable property updates.

As result

The bug is fixed
The app window is a little more responsive when resizing/moving

Before the change:

Maui.Controls.Sample_Xl8BmnifAD.mp4

MAUI.Windows.MultiDpi.monitor.mp4

After the fix

After.fix.mp4

Issues Fixed

Fixes (but reverted) #11777
Fixes (but reverted) #14597 (dupe)

ghost · 2023-05-01T14:07:19Z

Hey there @salarcode! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

salarcode · 2023-05-01T14:08:29Z

@dotnet-policy-service agree

mattleibow · 2023-05-03T17:26:48Z

/azp run

azure-pipelines · 2023-05-03T17:27:05Z

Azure Pipelines successfully started running 2 pipeline(s).

mattleibow

I wonder if this should actually make use of the new feature @hartez added with update direction. So when it is coming from the platform, we don't actually go back into the platform.

I think this is currently used on Android for entry text. It would go into this same cycle.

salarcode · 2023-05-07T23:43:27Z

I'm not sure if there is anything I need to do here?

salarcode · 2023-05-10T23:28:19Z

FYI this also affects Blazor Hybrid with .NET MAUI apps
And is a regression from .NET 6

mattleibow · 2023-05-11T05:22:30Z

I am not 100% sure that splitting up the bindable property is the correct action.

We do have a new way to track where the update comes from and we could use that instead.

@PureWeen do you have any thoughts?

hartez · 2023-05-16T17:31:32Z

I am not 100% sure that splitting up the bindable property is the correct action.

We do have a new way to track where the update comes from and we could use that instead.

We have DataFlowDirection, but that isn't really fully-baked yet; it was just the only option we had at the time. (That's why it's still marked as internal.) It would work for this situation, but it would be a little awkward because you'd have to force a cast to ViewHandler to set it. And we haven't really settled on that mechanism as a permanent solution.

My worry about the solution in this PR is that I think if you have anything with a data binding to one of the Window's frame properties, the value won't update. For example, if I bind a Label's Text property to the X property of the Window, does SetValuePrivateFlags.Silent keep the binding from updating?

mattleibow · 2023-05-17T04:21:24Z

@StephaneDelcroix are there thoughts?

salarcode · 2023-05-17T13:27:08Z

I am not 100% sure that splitting up the bindable property is the correct action.

I would prefer to have some kind of batch update as core functionality for bindable properties, something like this:

SetValueBatch((XProperty, x), (YProperty, y), (WidthProperty, width), (WidthProperty, width), (HeightProperty, height));


void SetValueBatch(params (BindableProperty property, object value)[] props)
{
	SetPropertyChanging(...);
	...
	SetValueCore(...);
	...
	SetPropertyChanged(...);
}

but this PR is a fix with what we have.

salarcode · 2023-05-17T13:31:25Z

My worry about the solution in this PR is that I think if you have anything with a data binding to one of the Window's frame properties, the value won't update. For example, if I bind a Label's Text property to the X property of the Window, does SetValuePrivateFlags.Silent keep the binding from updating?

That is taken care of here and it works fine as it can be tested in this sample:

maui/src/Controls/samples/Controls.Sample/Pages/Core/MultiWindowPage.xaml

Lines 18 to 22 in dec8b24

    
           <Label Text="Current Window Frame:" /> 
        
           <Label Text="{Binding Window.X, StringFormat='X = {0:0.00}'}" /> 
        
           <Label Text="{Binding Window.Y, StringFormat='Y = {0:0.00}'}" /> 
        
           <Label Text="{Binding Window.Width, StringFormat='W = {0:0.00}'}" /> 
        
           <Label Text="{Binding Window.Height, StringFormat='H = {0:0.00}'}" />

hartez · 2023-05-17T16:31:53Z

My worry about the solution in this PR is that I think if you have anything with a data binding to one of the Window's frame properties, the value won't update. For example, if I bind a Label's Text property to the X property of the Window, does SetValuePrivateFlags.Silent keep the binding from updating?

That is taken care of here and it works fine as it can be tested in this sample:

maui/src/Controls/samples/Controls.Sample/Pages/Core/MultiWindowPage.xaml

Lines 18 to 22 in dec8b24

<Label Text="Current Window Frame:" />

<Label Text="{Binding Window.X, StringFormat='X = {0:0.00}'}" />

<Label Text="{Binding Window.Y, StringFormat='Y = {0:0.00}'}" />

<Label Text="{Binding Window.Width, StringFormat='W = {0:0.00}'}" />

<Label Text="{Binding Window.Height, StringFormat='H = {0:0.00}'}" />

Then I don't have any objections to this.

salarcode · 2023-05-29T23:33:32Z

Any update on this?

mattleibow · 2023-05-30T11:36:40Z

I would like a review from @StephaneDelcroix just in case there is some side effect of doing this, especially in the light of the other changes he is doing.

StephaneDelcroix

looks fine, might need to be reviewed when my specificity PR is merged

salarcode · 2023-07-04T00:34:31Z

Any luck getting this in?

mattleibow · 2023-07-04T08:10:00Z

No idea how I missed the review from Stephane... Sorry about that.

@salarcode If you rebase so we can make sure all the new tests stick, I'll merge. If I rebase than I can't merge.

salarcode · 2023-07-06T01:34:16Z

No idea how I missed the review from Stephane... Sorry about that.

@salarcode If you rebase so we can make sure all the new tests stick, I'll merge. If I rebase than I can't merge.

No problem. It is done

mattleibow · 2023-07-06T23:19:59Z

/azp run

azure-pipelines · 2023-07-06T23:20:05Z

No commit pushedDate could be found for PR 14861 in repo dotnet/maui

rmarinho · 2023-07-18T16:51:18Z

/azp run

azure-pipelines · 2023-07-18T16:51:24Z

No commit pushedDate could be found for PR 14861 in repo dotnet/maui

rmarinho · 2023-07-18T16:51:56Z

/azp run

azure-pipelines · 2023-07-18T16:52:18Z

Azure Pipelines successfully started running 3 pipeline(s).

lfmouradasilva · 2023-07-20T21:58:31Z

Any forecast for this to be released? I have a problem in production

danielancines · 2023-07-20T21:58:56Z

Hi there, any idea when this fix is going to be released on .NET 7?
We are building a big software using .NET Maui and the app is crashing sometimes because of this error.

lfmouradasilva · 2023-07-20T22:13:44Z

Any workarounds?

Ajustes de pastas dll working

danielancines · 2023-07-24T10:45:15Z

Morning guys, I placed this code on my windows applications and it worked like a charm. Thank you, I hope this fix comes to official release soon.

rmarinho · 2023-07-24T11:07:19Z

Seems iOS is failing with a StackOverflow exception and I wonder if it's from the Window changes.

salarcode · 2023-07-26T05:15:28Z

I don't have an iOS device to test this, not sure why test is failing there, it was successful before! Maybe it`s something unrelated?

…4861)" This reverts commit e093edf.

…4861)" (#16541) This reverts commit e093edf.

salarcode · 2023-08-09T13:00:30Z

This fix does not work anymore after the commit 83398c38d0356c89e62c184ff088a992bb86c7d0 because the method SetValueCore does not respect SetValuePrivateFlags.Silent which it used to do

…zing (#14861)" (#16541)" This reverts commit 41af98e.

…16637) Initially merged in #14861 but there was a few test failures due to 83398c3 so it was reverted in #16541

* Add swipe for uitests * Bump the androidx group with 1 update (#16474) Bumps the androidx group with 1 update: [Xamarin.AndroidX.RecyclerView](https://github.com/xamarin/AndroidX). - [Commits](https://github.com/xamarin/AndroidX/commits) --- updated-dependencies: - dependency-name: Xamarin.AndroidX.RecyclerView dependency-type: direct:production update-type: version-update:semver-patch dependency-group: androidx ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Document Element (#16299) * Begin doc progress * Document element * More explicit interface implementations * Address PR feedback * Document interfaces + delete xml * whitespace * Prevent compile issues * Document IElementController (and mark as obsolete) * Remove Obsolete attribute from IElementController This would break the build in various places - and would go out of scope of the PR * Document IVusalElementController Apparently is only for internal use. We can't make it private so the only choice is to mark everything as for internal use only * Prevent mdoc from breaking You can't really cref a namespace * Fixed other crefs * Address Dave's feedback * Move powershell pack script into cake (#16588) * 'pwsh' is broken on net8 PowerShell/PowerShell#19679 * Remove the script * oops * Fix Graphics Font comparison method (#15985) * Fix the issue * Added more tests * Updated Impl * [WinUI] Implement PointerPressed and PointerReleased (#16213) * Implement on Windows and add unit tests * Update src/Controls/src/Core/PointerGestureRecognizer.cs Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> --------- Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> * [X] Optimize OnPlatform element syntax (#5611) * [X] Optimize OnPlatform element syntax - fixes #5583 * Auto-format source code * don't generate x:Name for removed OnPlatforms * Update src/Controls/src/SourceGen/Controls.SourceGen.csproj Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com> * fix string comparison --------- Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com> * [Housekeeping] Add 8.0 preview 7 (#16613) also adds a checkbox to make it clear if this is a regression or not * [X] Support DynResources as AppThemeBinding values (#16597) Because, you know, why not ? It could be useful - fixes #13619 * [main] Update dependencies from dotnet/xharness (#16600) * Update dependencies from https://github.com/dotnet/xharness build 20230807.2 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23403.1 -> To Version 8.0.0-prerelease.23407.2 * Run device tests on 16.4 * Force to 16.4 * Skip test that fails on iOS --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> * Adds prompts when creating a new page. (#16331) * Adds prompts when creating a new page. * Updates description as per suggested PR comments * [ios] fix memory leak in GraphicsView (#16605) Context: #16346 This addresses the memory leak discovered by: src/Core/src/Platform/iOS/PlatformTouchGraphicsView.cs(12,29): error MA0002: Member '_hoverGesture' could cause memory leaks in an NSObject subclass. Remove the member, store the value as a WeakReference, or add the [UnconditionalSuppressMessage("Memory", "MA0002")] attribute with a justification as to why the member will not leak. I could reproduce a leak in `MemoryTests.cs`: ++[InlineData(typeof(GraphicsView))] public async Task HandlerDoesNotLeak(Type type) Solved the problem by fixing two places: * `PlatformTouchGraphicsView` now stores the `IGraphicsView` as a `WeakReference`. * A `UIHoverGestureRecognizerProxy` is used for callbacks to the `UIHoverGestureRecognizer`. * [create-pull-request] automated change (#16592) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Setting binding on Label doesn't set text to incoming binding (#16410) * Test demonstrating binding issue * [C] SetBinding overrides SetValue, but only when the value is set * - reenable tests --------- Co-authored-by: Stephane Delcroix (HE/HIM) (from Dev Box) <stdelc@microsoft.com> * Added DeviceTest to validate CharacterSpacing on iOS Button (#16603) * Use runtime check for setting WKWebView inspectable flag (#16631) * Use runtime check * Remove private * Add back line * Line endings? * Use System.OperatingSystem * Update src/BlazorWebView/src/Maui/iOS/BlazorWebViewHandler.iOS.cs Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * [Housekeeping] Fix broken bug template (#16643) * [Housekeeping] Fix broken bug template checkbox <> checkboxes * Update bug-report.yml * Update bug-report.yml * Implement Additional PointerGestureRecognizer Platform Arguments (#16426) * Pointer Platform Event Args * remove extension and use property instead * make ctor internal * nullable consistency, spelling, and private setter * Public API changes and remove nullable windows routedargs * uitests part 1 * only run ui tests on windows and mac * move device conditional to test * Change the tests to Pointer Tests for more reusability * Add documentation * Add extension method for ignoring platforms * Update the documentation * Change platform specific docs * [C] fix Specificity for VSM (#16404) * [C] fix Specificity for VSM - fixes #11204 * remove skipped test * Prevent Android timer from adding multiple callbacks; (#16078) Fixes #10257 * [Housekeeping] Remove checkboxes from bug template (#16650) I did not realize that they would be editable tasks on the issue. Replaced with a dropdown. Also reordered the versions to be the most likely default options to speed up the reporting process. * [Android] Fix SwipeView not swiping using Label as direct content (#14824) * Fix Android SwipeView not swiping using Label as Content * Refactoring code * Added sample to validate 6154 --------- Co-authored-by: Javier Suárez <6755973+jsuarezruiz@users.noreply.github.com> * Locate MAUI View for PlatformView (#16463) * Locate xplat view from platformview * - dispatcher * - fix layout comparison on xunit * - PR review comments * - tizen fix * Bump the aspnetcore group with 7 updates (#16634) Bumps the aspnetcore group with 7 updates: | Package | Update | | --- | --- | | [Microsoft.AspNetCore.Authorization](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | | [Microsoft.AspNetCore.Components.WebView](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | | [Microsoft.JSInterop](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | | [Microsoft.AspNetCore.Components.Web](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | | [Microsoft.AspNetCore.Authentication.Facebook](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | | [Microsoft.AspNetCore.Authentication.Google](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | | [Microsoft.AspNetCore.Authentication.MicrosoftAccount](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | Updates `Microsoft.AspNetCore.Authorization` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) Updates `Microsoft.AspNetCore.Components.WebView` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) Updates `Microsoft.JSInterop` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) Updates `Microsoft.AspNetCore.Components.Web` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) Updates `Microsoft.AspNetCore.Authentication.Facebook` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) Updates `Microsoft.AspNetCore.Authentication.Google` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) Updates `Microsoft.AspNetCore.Authentication.MicrosoftAccount` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authorization dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Components.WebView dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.JSInterop dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Components.Web dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Authentication.Facebook dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [create-pull-request] automated change (#16655) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [ios] fix memory leak in SwipeItem (#16614) Context: #16346 This addresses the memory leak discovered by: src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs(10,30): error MA0001: Event 'FrameChanged' could cause memory leaks in an NSObject subclass. Remove the event or add the [UnconditionalSuppressMessage("Memory", "MA0001")] attribute with a justification as to why the event will not leak. I could reproduce the leak with a custom test in `SwipeViewTests`. Solved the problem by introducing `SwipeItemButtonProxy` with the same pattern from other PRs. * [ios/catalyst] fix memory leak in DatePicker (#16589) Context: #16346 This addresses the memory leak discovered by: src/Core/src/Platform/iOS/MauiDatePicker.cs(37,27): error MA0003: Subscribing to events with instance method 'OnValueChanged' could cause memory leaks in an NSObject subclass. Remove the subscription or convert the method to a static method. I could reproduce a leak in `MemoryTests.cs`: ++[InlineData(typeof(DatePicker))] public async Task HandlerDoesNotLeak(Type type) Solved the problem by fixing two places: * `MauiDatePicker` now uses a `UIDatePickerProxy` type, for iOS * `DatePickerHandler.MacCatalyst.cs` now uses a `UIDatePickerProxy` type, for MacCatalyst. Other changes: * Skip test on Android API 23 This is working for me locally on an API 23 emulator -- so I don't think it is really leaking. We skipped API 23 in another place: https://github.com/dotnet/maui/blob/9fcccd57b5a3d664e4788b3c7fc3edc10010beaf/src/Controls/tests/DeviceTests/Elements/NavigationPage/NavigationPageTests.cs#L302-L303 We are more interested in iOS on this PR anyway. * [build] Bump XCode to 14.31 (#16374) * Add doc comments for common types used in templates, maps, webview (#16552) * Add doc comments for common types used in templates, maps, webview * Enable WarnigsAsErrors for inline docs on Maps I went through every type/method/etc. used in the default MAUI app template and ensured there are doc for all of them. I also added a few miscellaneous docs for WebView types and Map (many were copied from Xamarin.Forms docs). --------- Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Update CODEOWNERS (#16682) * Fix the case where silent was requested (#16676) * Use the correct WASDK property (#16683) * Re-land "[Windows] fixing window glitches while moving or resizing" (#16637) Initially merged in #14861 but there was a few test failures due to 83398c3 so it was reverted in #16541 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20230815.5 Microsoft.tvOS.Sdk From Version 16.4.8694-net8-p7 -> To Version 16.4.8751-net8-rc1 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20230815.5 Microsoft.MacCatalyst.Sdk From Version 16.4.8694-net8-p7 -> To Version 16.4.8751-net8-rc1 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20230815.5 Microsoft.macOS.Sdk From Version 13.3.8694-net8-p7 -> To Version 13.3.8751-net8-rc1 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20230815.5 Microsoft.iOS.Sdk From Version 16.4.8694-net8-p7 -> To Version 16.4.8751-net8-rc1 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Scott Banning <scoban@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Rachel Kang <rachelkang@microsoft.com> Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Mausam Shrestha <46900712+mausam-shrestha@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: Stephane Delcroix (HE/HIM) (from Dev Box) <stdelc@microsoft.com> Co-authored-by: Tim Miller <drasticactions@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: Javier Suárez <6755973+jsuarezruiz@users.noreply.github.com> Co-authored-by: scoban <sbanni@users.noreply.github.com> Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com>

Window glitch fix for windows

774b5c9

ghost added the community ✨ Community Contribution label May 1, 2023

jsuarezruiz added the platform/windows label May 2, 2023

Eilon added the legacy-area-desktop Windows / WinUI / Project Reunion & Mac Catalyst / macOS specifics (Menus & other Controls)) label May 2, 2023

Minor refactoring

8dcb62f

mattleibow reviewed May 4, 2023

View reviewed changes

jsuarezruiz requested a review from hartez May 10, 2023 16:34

mattleibow mentioned this pull request May 12, 2023

[Windows] Flyout changes page's content width. #15033

Closed

StephaneDelcroix reviewed May 31, 2023

View reviewed changes

mattleibow approved these changes Jul 4, 2023

View reviewed changes

Merge branch 'main' into 11777-window-glitch-fix-on-Wndows

24d45a1

mattleibow approved these changes Jul 6, 2023

View reviewed changes

jsuarezruiz approved these changes Jul 19, 2023

View reviewed changes

danielancines added a commit to danielancines/maui that referenced this pull request Jul 21, 2023

Antecipacao do fix: dotnet#14861

55a325d

danielancines added a commit to danielancines/maui that referenced this pull request Jul 24, 2023

Antecipacao do fix: dotnet#14861

aa24806

Ajustes de pastas dll working

samhouts added this to the .NET 8 GA milestone Jul 26, 2023

rmarinho enabled auto-merge (squash) August 3, 2023 14:22

rmarinho merged commit e093edf into dotnet:main Aug 3, 2023

rmarinho added a commit that referenced this pull request Aug 4, 2023

Revert "[Windows] fixing window glitches while moving or resizing (#1…

7b365eb

…4861)" This reverts commit e093edf.

rmarinho added a commit that referenced this pull request Aug 4, 2023

Revert "[Windows] fixing window glitches while moving or resizing (#1…

41af98e

…4861)" (#16541) This reverts commit e093edf.

mattleibow added a commit that referenced this pull request Aug 9, 2023

Revert "Revert "[Windows] fixing window glitches while moving or resi…

ffe6ba8

…zing (#14861)" (#16541)" This reverts commit 41af98e.

mattleibow mentioned this pull request Aug 9, 2023

Re-land "[Windows] fixing window glitches while moving or resizing" #16637

Merged

mattleibow added a commit that referenced this pull request Aug 11, 2023

Re-land "[Windows] fixing window glitches while moving or resizing" (#…

412eb05

…16637) Initially merged in #14861 but there was a few test failures due to 83398c3 so it was reverted in #16541

github-actions bot locked and limited conversation to collaborators Dec 10, 2023

Eilon added t/desktop The issue relates to desktop scenarios (MacOS/MacCatalyst/Windows/WinUI/WinAppSDK) area-controls-window Window and removed legacy-area-desktop Windows / WinUI / Project Reunion & Mac Catalyst / macOS specifics (Menus & other Controls)) labels May 10, 2024

samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Aug 2, 2024

Conversation

salarcode commented May 1, 2023 • edited by samhouts Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Issues Fixed

Uh oh!

ghost commented May 1, 2023

Uh oh!

salarcode commented May 1, 2023

Uh oh!

mattleibow commented May 3, 2023

Uh oh!

azure-pipelines bot commented May 3, 2023

Uh oh!

mattleibow left a comment

Choose a reason for hiding this comment

Uh oh!

salarcode commented May 7, 2023

Uh oh!

salarcode commented May 10, 2023

Uh oh!

mattleibow commented May 11, 2023

Uh oh!

hartez commented May 16, 2023

Uh oh!

mattleibow commented May 17, 2023

Uh oh!

salarcode commented May 17, 2023

Uh oh!

salarcode commented May 17, 2023

Uh oh!

hartez commented May 17, 2023

Uh oh!

salarcode commented May 29, 2023

Uh oh!

mattleibow commented May 30, 2023

Uh oh!

StephaneDelcroix left a comment

Choose a reason for hiding this comment

Uh oh!

salarcode commented Jul 4, 2023

Uh oh!

mattleibow commented Jul 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

salarcode commented Jul 6, 2023

Uh oh!

mattleibow commented Jul 6, 2023

Uh oh!

azure-pipelines bot commented Jul 6, 2023

Uh oh!

rmarinho commented Jul 18, 2023

Uh oh!

azure-pipelines bot commented Jul 18, 2023

Uh oh!

rmarinho commented Jul 18, 2023

Uh oh!

azure-pipelines bot commented Jul 18, 2023

Uh oh!

lfmouradasilva commented Jul 20, 2023

Uh oh!

danielancines commented Jul 20, 2023

Uh oh!

lfmouradasilva commented Jul 20, 2023

Uh oh!

danielancines commented Jul 24, 2023

Uh oh!

rmarinho commented Jul 24, 2023

Uh oh!

salarcode commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

salarcode commented Aug 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

salarcode commented May 1, 2023 •

edited by samhouts

Loading

mattleibow commented Jul 4, 2023 •

edited

Loading

salarcode commented Jul 26, 2023 •

edited

Loading