Skip to content

[foldable] XML doc additions#10972

Merged
jfversluis merged 2 commits intodotnet:mainfrom
conceptdev:conceptdev/foldable-api-docs
Nov 3, 2022
Merged

[foldable] XML doc additions#10972
jfversluis merged 2 commits intodotnet:mainfrom
conceptdev:conceptdev/foldable-api-docs

Conversation

@conceptdev
Copy link
Copy Markdown
Contributor

Description of Change

The Xamarin.Forms TwoPaneView had API documentation available.

This PR includes those API docs (with improvements) as triple-slash XML comments in the .NET MAUI Foldable namespace.

Issues Fixed

Related to #3960

@conceptdev conceptdev added the area-docs Conceptual docs, API docs, Samples label Oct 27, 2022
@conceptdev conceptdev requested a review from jfversluis October 27, 2022 23:44
@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@hartez
Copy link
Copy Markdown
Contributor

hartez commented Nov 1, 2022

@conceptdev Any reason this is still a draft?

@conceptdev
Copy link
Copy Markdown
Contributor Author

@hartez only to prevent it accidentally being merged without someone taking a look at it... esp since the guidance suggested I target main branch but wasn't sure if it should be the net7.0 branch. Otherwise it's ready to merge AFAIC.

@conceptdev
Copy link
Copy Markdown
Contributor Author

Upon checking some other api doc PRs, they seem to target main so I'm changing this from Draft to Ready for review

@conceptdev conceptdev marked this pull request as ready for review November 2, 2022 17:16
@jfversluis jfversluis merged commit a48dabc into dotnet:main Nov 3, 2022
jfversluis pushed a commit that referenced this pull request Nov 3, 2022
hartez pushed a commit that referenced this pull request Nov 3, 2022
Co-authored-by: Craig Dunn <craig.dunn@microsoft.com>
@conceptdev conceptdev deleted the conceptdev/foldable-api-docs branch November 3, 2022 22:57
@dotnet dotnet deleted a comment from github-actions bot Nov 18, 2022
@dotnet dotnet deleted a comment from github-actions bot Nov 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-docs Conceptual docs, API docs, Samples fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! t/housekeeping ♻︎

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants