Skip to content

[d16-3] [GameController] GCGamepad is deprecated in the headers, so mark it as such. Fixes xamarin/maccore#1742.#6429

Merged
rolfbjarne merged 2 commits intodotnet:d16-3from
monojenkins:backport-pr-6417-to-d16-3
Jun 27, 2019
Merged

[d16-3] [GameController] GCGamepad is deprecated in the headers, so mark it as such. Fixes xamarin/maccore#1742.#6429
rolfbjarne merged 2 commits intodotnet:d16-3from
monojenkins:backport-pr-6417-to-d16-3

Conversation

@monojenkins
Copy link
Copy Markdown
Contributor

@monojenkins monojenkins commented Jun 26, 2019

@monojenkins monojenkins added this to the d16-3 milestone Jun 26, 2019
@rolfbjarne rolfbjarne requested a review from chamons June 26, 2019 07:29
@monojenkins
Copy link
Copy Markdown
Contributor Author

monojenkins commented Jun 26, 2019

Build failure
✅ Build succeeded
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    ** Error: Working directory isn't clean:
    HEAD detached at 46d5fdf
    Untracked files:
    (use "git add ..." to include in what will be committed)
    
    tests/bcl-test/BCL tests group 1.csproj
    tests/bcl-test/BCL tests group 2.csproj
    tests/bcl-test/BCL tests group 3.csproj
    tests/bcl-test/BCL tests group 4.csproj
    tests/bcl-test/BCL tests group 6.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-modern.csproj
    tests/bcl-test/generated/
    tests/bcl-test/mscorlib-mac-full.csproj
    tests/bcl-test/mscorlib-mac-modern.csproj
    tests/bcl-test/mscorlib.csproj
    
    nothing added to commit but untracked files present (use "git add" to track)
    Search for Comparing API & creating generator diff in the log to view the complete log.
🔥 Test run failed 🔥

Test results

1 tests failed, 94 tests passed.

Failed tests

  • MSBuild tests/iOS: Failed (Execution failed with exit code 1)

@rolfbjarne rolfbjarne mentioned this pull request Jun 26, 2019
Merged
@rolfbjarne
Copy link
Copy Markdown
Member

rolfbjarne commented Jun 26, 2019

Test failure is unrelated and will be fixed with PR #6427.

@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Jun 27, 2019
@rolfbjarne rolfbjarne merged commit 9e902c5 into dotnet:d16-3 Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@VincentDondain VincentDondain Awaiting requested review from VincentDondain

@chamons chamons Awaiting requested review from chamons

+3 more reviewers

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@stephen-hawley stephen-hawley stephen-hawley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Milestone

d16-3

Development

Successfully merging this pull request may close these issues.

6 participants

@monojenkins @rolfbjarne @dalexsoto @spouliot @mandel-macaque @stephen-hawley