Skip to content

[GameController] GCGamepad is deprecated in the headers, so mark it as such. Fixes xamarin/maccore#1742.#6417

Merged
rolfbjarne merged 2 commits intodotnet:masterfrom
rolfbjarne:maccore-issue-1742
Jun 26, 2019
Merged

[GameController] GCGamepad is deprecated in the headers, so mark it as such. Fixes xamarin/maccore#1742.#6417
rolfbjarne merged 2 commits intodotnet:masterfrom
rolfbjarne:maccore-issue-1742

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

@rolfbjarne rolfbjarne commented Jun 25, 2019

@monojenkins
Copy link
Copy Markdown
Contributor

monojenkins commented Jun 25, 2019

Build failure
✅ Build succeeded
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    ** Error: Working directory isn't clean:
    HEAD detached at ac58eec
    Untracked files:
    (use "git add ..." to include in what will be committed)
    
    tests/bcl-test/BCL tests group 1.csproj
    tests/bcl-test/BCL tests group 2.csproj
    tests/bcl-test/BCL tests group 3.csproj
    tests/bcl-test/BCL tests group 4.csproj
    tests/bcl-test/BCL tests group 6.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-modern.csproj
    tests/bcl-test/generated/
    tests/bcl-test/mscorlib-mac-full.csproj
    tests/bcl-test/mscorlib-mac-modern.csproj
    tests/bcl-test/mscorlib.csproj
    
    nothing added to commit but untracked files present (use "git add" to track)
    Search for Comparing API & creating generator diff in the log to view the complete log.
✅ Test run succeeded

spouliot
spouliot suggested changes Jun 25, 2019
View reviewed changes
src/gamecontroller.cs
[iOS (7,0)]
[Mac (10,9, onlyOn64: true)]
[Deprecated (PlatformName.MacOSX, 10, 12)]
[Deprecated (PlatformName.iOS, 10, 0)]
Copy link
Copy Markdown
Contributor

@spouliot spouliot Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need a tvOS entry too - it's implied as always available in tvOS (by [iOS (7,0)]) but that does not apply to deprecation

Copy link
Copy Markdown
Contributor

@spouliot spouliot Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still strange that this happens only in some, not all bots :|

@monojenkins

This comment has been minimized.

Sign in to view
@rolfbjarne rolfbjarne force-pushed the maccore-issue-1742 branch from 08399d3 to 849e155 Compare June 25, 2019 17:12
dalexsoto
dalexsoto approved these changes Jun 25, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Sebastien comments are addressed, weird that it happens randomly :/

@monojenkins
Copy link
Copy Markdown
Contributor

monojenkins commented Jun 25, 2019

Build failure
✅ Build succeeded
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    ** Error: Working directory isn't clean:
    HEAD detached at 07b81ff
    Untracked files:
    (use "git add ..." to include in what will be committed)
    
    tests/bcl-test/BCL tests group 1.csproj
    tests/bcl-test/BCL tests group 2.csproj
    tests/bcl-test/BCL tests group 3.csproj
    tests/bcl-test/BCL tests group 4.csproj
    tests/bcl-test/BCL tests group 6.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-modern.csproj
    tests/bcl-test/generated/
    tests/bcl-test/mscorlib-mac-full.csproj
    tests/bcl-test/mscorlib-mac-modern.csproj
    tests/bcl-test/mscorlib.csproj
    
    nothing added to commit but untracked files present (use "git add" to track)
    Search for Comparing API & creating generator diff in the log to view the complete log.
✅ Test run succeeded

@rolfbjarne rolfbjarne merged commit 55887ca into dotnet:master Jun 26, 2019
@rolfbjarne
Copy link
Copy Markdown
Member Author

rolfbjarne commented Jun 26, 2019

@monojenkins backport d16-2
@monojenkins backport d16-3

This was referenced Jun 26, 2019
Merged
Merged
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Jun 27, 2019
rolfbjarne added a commit that referenced this pull request Jul 24, 2019
@rolfbjarne
[GameController] GCGamepad is deprecated in the headers, so mark it a…
c179463 
…s such. Fixes xamarin/maccore#1742. (#6417)

* [GameController] GCGamepad is deprecated in the headers, so mark it as such. Fixes xamarin/maccore#1742.

Fixes xamarin/maccore#1742.

* Add attribute for tvOS too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

+5 more reviewers

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@chamons chamons chamons approved these changes

@VincentDondain VincentDondain VincentDondain approved these changes

@whitneyschmidt whitneyschmidt whitneyschmidt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@rolfbjarne @monojenkins @dalexsoto @spouliot @mandel-macaque @chamons @VincentDondain @whitneyschmidt