[dotnet] Fix handling binding frameworks embedded in binding assemblies remotely. by rolfbjarne · Pull Request #24518 · dotnet/macios

rolfbjarne · 2026-01-16T10:44:23Z

Adjust the FilterStaticFrameworks and GetFullPaths tasks to not copy any empty files
from Windows to Mac, because that would most likely overwrite an existing non-empty
file on the Mac.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2679691.

…es remotely. Adjust the FilterStaticFrameworks and GetFullPaths tasks to not copy any empty files from Windows to Mac, because that would most likely overwrite an existing non-empty file on the Mac. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2679691.

Copilot

Pull request overview

This pull request fixes handling of binding frameworks embedded in binding assemblies when building remotely on Windows with a Mac build server. The fix prevents empty placeholder files created on Windows from being copied to the Mac, which would overwrite the actual non-empty framework files.

Changes:

Modified MSBuild tasks to check file size before copying to build server and skip empty files
Added new test projects to validate the fix for embedded frameworks in binding projects

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
msbuild/Xamarin.MacDev.Tasks/Tasks/GetFullPaths.cs	Added empty file check in ShouldCopyToBuildServer to prevent overwriting Mac files
msbuild/Xamarin.MacDev.Tasks/Tasks/FilterStaticFrameworks.cs	Added empty file check in GetAdditionalItemsToBeCopied to skip copying empty framework files
tests/dotnet/UnitTests/WindowsTest.cs	Added test case to verify building embedded framework in binding project on Windows
tests/dotnet/BindingWithEmbeddedFramework/*	New binding project with embedded XTest.framework for testing
tests/dotnet/EmbeddedFrameworkInBindingProjectApp/*	New test app consuming the binding project with embedded framework
tests/bindings-framework-test/dotnet/shared.csproj	Made NoBindingEmbedding conditional to allow override in tests

msbuild/Xamarin.MacDev.Tasks/Tasks/FilterStaticFrameworks.cs

Copilot · 2026-01-16T10:54:22Z

msbuild/Xamarin.MacDev.Tasks/Tasks/GetFullPaths.cs

-		public bool ShouldCopyToBuildServer (ITaskItem item) => true;
+		public bool ShouldCopyToBuildServer (ITaskItem item)
+		{
+


There is an extra blank line at the beginning of this method. According to the repository's coding guidelines, diffs should be as small as possible and preserve existing code formatting. This extra blank line should be removed.

Copilot · 2026-01-16T10:54:23Z

tests/dotnet/UnitTests/WindowsTest.cs

+			Configuration.AssertRuntimeIdentifiersAvailable (platform, runtimeIdentifiers);
+			Configuration.IgnoreIfNotOnWindows ();
+
+			var project_path = GetProjectPath (project, runtimeIdentifiers: runtimeIdentifiers, platform: platform, out var appPath, configuration: configuration);


The variable 'appPath' is declared but never used in this test method. Consider removing the 'out var appPath' parameter from the GetProjectPath call if it's not needed.

Suggested change

var project_path = GetProjectPath (project, runtimeIdentifiers: runtimeIdentifiers, platform: platform, out var appPath, configuration: configuration);

var project_path = GetProjectPath (project, runtimeIdentifiers: runtimeIdentifiers, platform: platform, configuration: configuration);

Copilot · 2026-01-16T10:54:23Z

tests/dotnet/UnitTests/WindowsTest.cs

+			Configuration.IgnoreIfNotOnWindows ();
+
+			var project_path = GetProjectPath (project, runtimeIdentifiers: runtimeIdentifiers, platform: platform, out var appPath, configuration: configuration);
+			var project_dir = Path.GetDirectoryName (project_path)!;


The variable 'project_dir' is declared but never used in this test method. Consider removing this unused variable declaration.

Suggested change

var project_dir = Path.GetDirectoryName (project_path)!;

This reverts commit d79b463. wrong branch

vs-mobiletools-engineering-service2 · 2026-01-19T12:20:52Z

✅ [CI Build #633beb1] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 633beb1fc2c0b67b7116df3b5669ad9367c973f3 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T12:23:40Z

✅ [PR Build #633beb1] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 633beb1fc2c0b67b7116df3b5669ad9367c973f3 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T12:49:45Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 633beb1fc2c0b67b7116df3b5669ad9367c973f3 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T12:55:39Z

✅ [CI Build #633beb1] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 633beb1fc2c0b67b7116df3b5669ad9367c973f3 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T13:05:26Z

💻 [CI Build #633beb1] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 633beb1fc2c0b67b7116df3b5669ad9367c973f3 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T13:09:16Z

💻 [CI Build #633beb1] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 633beb1fc2c0b67b7116df3b5669ad9367c973f3 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T13:09:51Z

💻 [CI Build #633beb1] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 633beb1fc2c0b67b7116df3b5669ad9367c973f3 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T13:11:48Z

💻 [CI Build #633beb1] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 633beb1fc2c0b67b7116df3b5669ad9367c973f3 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T20:23:29Z

💻 [CI Build #633beb1] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 633beb1fc2c0b67b7116df3b5669ad9367c973f3 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T20:43:39Z

🚀 [CI Build #633beb1] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 121 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 633beb1fc2c0b67b7116df3b5669ad9367c973f3 [PR build]

…in binding assemblies remotely. (#24538) Adjust the FilterStaticFrameworks and GetFullPaths tasks to not copy any empty files from Windows to Mac, because that would most likely overwrite an existing non-empty file on the Mac. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2679691. Backport of #24518.

…n binding assemblies remotely. (#24548) Adjust the FilterStaticFrameworks and GetFullPaths tasks to not copy any empty files from Windows to Mac, because that would most likely overwrite an existing non-empty file on the Mac. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2679691. Backport of #24518.

rolfbjarne requested review from emaf and mauroa as code owners January 16, 2026 10:44

rolfbjarne requested a review from Copilot January 16, 2026 10:44

Copilot started reviewing on behalf of rolfbjarne January 16, 2026 10:44 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

tweaks

09e3f41

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits January 19, 2026 12:49

No SetupOSSpecificProps target.

d79b463

Revert "No SetupOSSpecificProps target."

633beb1

This reverts commit d79b463. wrong branch

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jan 20, 2026

View reviewed changes

emaf approved these changes Jan 21, 2026

View reviewed changes

rolfbjarne merged commit 36c83c7 into main Jan 22, 2026
45 checks passed

rolfbjarne mentioned this pull request Jan 22, 2026

[release/10.0.1xx] [dotnet] Fix handling binding frameworks embedded in binding assemblies remotely. #24538

Merged

rolfbjarne mentioned this pull request Jan 22, 2026

[release/9.0.1xx] [dotnet] Fix handling binding frameworks embedded in binding assemblies remotely. #24548

Merged

	var project_path = GetProjectPath (project, runtimeIdentifiers: runtimeIdentifiers, platform: platform, out var appPath, configuration: configuration);
	var project_path = GetProjectPath (project, runtimeIdentifiers: runtimeIdentifiers, platform: platform, configuration: configuration);

Conversation

rolfbjarne commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 19, 2026

✅ [CI Build #633beb1] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 19, 2026

✅ [PR Build #633beb1] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 19, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 19, 2026

✅ [CI Build #633beb1] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 19, 2026

💻 [CI Build #633beb1] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 19, 2026

💻 [CI Build #633beb1] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 19, 2026

💻 [CI Build #633beb1] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 19, 2026

💻 [CI Build #633beb1] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 19, 2026

💻 [CI Build #633beb1] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!