Skip to content

[msbuild] Fix confusion about where the codesign[-bundle].items files are stored. Fixes #24052.#24198

Merged
dalexsoto merged 1 commit intomainfrom
dev/rolf/issue-24052-codesign-extensions
Nov 7, 2025
Merged

[msbuild] Fix confusion about where the codesign[-bundle].items files are stored. Fixes #24052.#24198
dalexsoto merged 1 commit intomainfrom
dev/rolf/issue-24052-codesign-extensions

Conversation

@rolfbjarne
Copy link
Member

They're always stored locally.

This fixes an issue when building apps with extensions from Windows.

There are no tests, because there's another issue that breaks building
extensions from Windows (#23516), but the customer validated that the fix
works for him, and the fix also makes sense.

Fixes #24052.

… are stored. Fixes #24052.

They're always stored locally.

This fixes an issue when building apps with extensions from Windows.

There are no tests, because there's another issue that breaks building
extensions from Windows (#23516), but the customer validated that the fix
works for him, and the fix also makes sense.

Fixes #24052.
@rolfbjarne
Copy link
Member Author

@dalexsoto it would be good to get this one in .NET9/10 as well.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #3b08505] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 3b085051ccfc938e1133e50ebc7b540529bfdeb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #3b08505] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 3b085051ccfc938e1133e50ebc7b540529bfdeb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 3b085051ccfc938e1133e50ebc7b540529bfdeb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #3b08505] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 3b085051ccfc938e1133e50ebc7b540529bfdeb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #3b08505] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 3b085051ccfc938e1133e50ebc7b540529bfdeb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #3b08505] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 3b085051ccfc938e1133e50ebc7b540529bfdeb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #3b08505] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 3b085051ccfc938e1133e50ebc7b540529bfdeb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #3b08505] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 3b085051ccfc938e1133e50ebc7b540529bfdeb0 [PR build]

@dalexsoto
Copy link
Member

@dalexsoto it would be good to get this one in .NET9/10 as well.

Backport it!

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #3b08505] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 3b085051ccfc938e1133e50ebc7b540529bfdeb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #3b08505] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 3b085051ccfc938e1133e50ebc7b540529bfdeb0 [PR build]

@dalexsoto dalexsoto merged commit d2745b2 into main Nov 7, 2025
45 checks passed
dalexsoto pushed a commit that referenced this pull request Nov 7, 2025
… are stored. Fixes #24052. (#24198)

They're always stored locally.

This fixes an issue when building apps with extensions from Windows.

There are no tests, because there's another issue that breaks building
extensions from Windows (#23516), but the customer validated that the
fix
works for him, and the fix also makes sense.

Fixes #24052.
dalexsoto pushed a commit that referenced this pull request Nov 7, 2025
… are stored. Fixes #24052. (#24198)

They're always stored locally.

This fixes an issue when building apps with extensions from Windows.

There are no tests, because there's another issue that breaks building
extensions from Windows (#23516), but the customer validated that the
fix
works for him, and the fix also makes sense.

Fixes #24052.
rolfbjarne pushed a commit that referenced this pull request Nov 7, 2025
…bundle].items files are stored. Fixes #24052. (#24201)

They're always stored locally.

This fixes an issue when building apps with extensions from Windows.

There are no tests, because there's another issue that breaks building extensions from Windows (#23516), but the customer validated that the fix
works for him, and the fix also makes sense.

Fixes #24052.

Backport of #24198.
rolfbjarne pushed a commit that referenced this pull request Nov 7, 2025
…undle].items files are stored. Fixes #24052. (#24200)

They're always stored locally.

This fixes an issue when building apps with extensions from Windows.

There are no tests, because there's another issue that breaks building extensions from Windows (#23516), but the customer validated that the fix
works for him, and the fix also makes sense.

Fixes #24052.

Backport of #24198.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to build iOS app with extension .NET9

3 participants