Set a default for the Http3Support feature switch#23221
Closed
MichalStrehovsky wants to merge 1 commit intodotnet:mainfrom
Closed
Set a default for the Http3Support feature switch#23221MichalStrehovsky wants to merge 1 commit intodotnet:mainfrom
MichalStrehovsky wants to merge 1 commit intodotnet:mainfrom
Conversation
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting. Ref dotnet/runtime#117012 Ref dotnet/sdk#49564
Member
|
@MichalStrehovsky did http3 ever work on Apple platforms? |
Member
|
Closing in favor of #23223, because our CI can't work with pull requests from forks. |
Member
Author
It didn't. There was hardcoded logic in System.Net.Http that allowed this code to also be trimmed away. I'm making this a feature switch instead of a hardcoded check, so we need to set a default for the feature switch to keep the trimming behavior. |
rolfbjarne
added a commit
that referenced
this pull request
Jul 3, 2025
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting. Ref dotnet/runtime#117012 Ref dotnet/sdk#49564 This is a re-creation of #23221 using origin, since we can't build PRs from forks. --------- Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting.
Ref dotnet/runtime#117012
Ref dotnet/sdk#49564