Skip to content

[AppKit] Add a few missing NullAllowed attributes. Fixes #18115.#18118

Merged
rolfbjarne merged 1 commit intodotnet:mainfrom
rolfbjarne:issue-18115
Apr 25, 2023
Merged

[AppKit] Add a few missing NullAllowed attributes. Fixes #18115.#18118
rolfbjarne merged 1 commit intodotnet:mainfrom
rolfbjarne:issue-18115

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Apr 24, 2023

Fixes #18115.

@rolfbjarne rolfbjarne requested a review from dalexsoto as a code owner April 24, 2023 08:02
@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Apr 24, 2023
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 24, 2023

❌ [CI Build] Windows Integration Tests failed ❌

❌ SucceededWithIssues ❌

Pipeline on Agent
Hash: d4907d5e6ecd4d2ed291d2d6842285f2d1d6aabd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 24, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1177.Ventura
Hash: d4907d5e6ecd4d2ed291d2d6842285f2d1d6aabd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 24, 2023

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: d4907d5e6ecd4d2ed291d2d6842285f2d1d6aabd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 24, 2023

❌ [PR Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 24, 2023

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 24, 2023

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 2 tests failed, 223 tests passed.

Failures

❌ monotouch tests

2 tests failed, 23 tests passed.
Details
  • monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)
  • monotouch-test/Mac Catalyst [dotnet]/Release [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: d4907d5e6ecd4d2ed291d2d6842285f2d1d6aabd [PR build]

@rolfbjarne
Copy link
Member Author

rolfbjarne commented Apr 25, 2023

Test failures are unrelated (#18121).

@rolfbjarne rolfbjarne merged commit c9cb8ca into dotnet:main Apr 25, 2023
@rolfbjarne rolfbjarne deleted the issue-18115 branch April 25, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tj-devel709 tj-devel709 tj-devel709 approved these changes

@dalexsoto dalexsoto Awaiting requested review from dalexsoto dalexsoto is a code owner

+1 more reviewer

@haritha-mohan haritha-mohan haritha-mohan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug If an issue is a bug or a pull request a bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TextColor on NSTextField and NSTextFieldCell should allow null values.

4 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @tj-devel709 @haritha-mohan