Skip to content

[msbuild] Add a public 'CompileImageAssetsDependsOn' property. Fixes #16065. #16089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rolfbjarne merged 1 commit into from
Sep 23, 2022
Merged

[msbuild] Add a public 'CompileImageAssetsDependsOn' property. Fixes #16065. #16089

rolfbjarne merged 1 commit into from
Sep 23, 2022

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Sep 22, 2022

Add a public 'CompileImageAssetsDependsOn' property, so that MAUI can inject tasks that
must be completed before we compile image assets:

<PropertyGroup>
	<CompileImageAssetsDependsOn>
		$(CompileImageAssetsDependsOn);
		ResizetizeCollectItems;
	</CompileImageAssetsDependsOn>
</PropertyGroup>

Fixes #16065.

@rolfbjarne
[msbuild] Add a public 'CompileImageAssetsDependsOn' property. Fixes d…
7f72e11 
…otnet#16065.

Add a public 'CompileImageAssetsDependsOn' property, so that MAUI can inject tasks that
must be completed before we compile image assets:

```xml
<PropertyGroup>
	<CompileImageAssetsDependsOn>
		$(CompileImageAssetsDependsOn);
		ResizetizeCollectItems;
	</CompileImageAssetsDependsOn>
</PropertyGroup>
```

Fixes dotnet#16065.
@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Sep 22, 2022
@rolfbjarne rolfbjarne mentioned this pull request Sep 22, 2022
Closed
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 22, 2022

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1106.Monterey'
Hash: 7e2e1875fd9eaf9906e489447f6bcfea471d3f0d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 22, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 7e2e1875fd9eaf9906e489447f6bcfea471d3f0d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 22, 2022

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 7e2e1875fd9eaf9906e489447f6bcfea471d3f0d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 22, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • xammac_tests

Pipeline on Agent
Hash: 7e2e1875fd9eaf9906e489447f6bcfea471d3f0d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 22, 2022

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 2 tests failed, 221 tests passed.

Failures

❌ mononative tests

2 tests failed, 10 tests passed.
Details
  • mono-native-compat/tvOS - simulator/Debug: LaunchTimedOut
  • mono-native-unified/tvOS - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne
Copy link
Member Author

rolfbjarne commented Sep 23, 2022

Test failures are unrelated (https://github.com/xamarin/maccore/issues/2450).

@rolfbjarne rolfbjarne merged commit 8a91560 into dotnet:main Sep 23, 2022
@rolfbjarne rolfbjarne deleted the issue-16065 branch September 23, 2022 14:29
@rolfbjarne
Copy link
Member Author

rolfbjarne commented Sep 23, 2022

/sudo backport release/7.0.1xx-rc2

@rolfbjarne
Copy link
Member Author

rolfbjarne commented Sep 23, 2022

/sudo backport release/7.0.1xx-xcode14-rc2

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 23, 2022

Backport Job to branch release/7.0.1xx-xcode14-rc2 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 23, 2022

Backport Job to branch release/7.0.1xx-rc2 Created! The magic is happening here

This was referenced Sep 23, 2022
Merged
Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 23, 2022

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6731173 for more details.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 23, 2022

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6731174 for more details.

rolfbjarne added a commit that referenced this pull request Sep 23, 2022
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/7.0.1xx-xcode14-rc2] [msbuild] Add a public 'CompileImageAss…
b179676 
…etsDependsOn' property. Fixes #16065. (#16111)

Add a public 'CompileImageAssetsDependsOn' property, so that MAUI can inject tasks that
must be completed before we compile image assets:

```xml
<PropertyGroup>
	<CompileImageAssetsDependsOn>
		$(CompileImageAssetsDependsOn);
		ResizetizeCollectItems;
	</CompileImageAssetsDependsOn>
</PropertyGroup>
```

Fixes #16065.

Backport of #16089

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
dalexsoto pushed a commit that referenced this pull request Sep 26, 2022
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/7.0.1xx-rc2] [msbuild] Add a public 'CompileImageAssetsDepen…
e1d4531 
…dsOn' property. Fixes #16065. (#16112)

Add a public 'CompileImageAssetsDependsOn' property, so that MAUI can
inject tasks that
must be completed before we compile image assets:

```xml
<PropertyGroup>
	<CompileImageAssetsDependsOn>
		$(CompileImageAssetsDependsOn);
		ResizetizeCollectItems;
	</CompileImageAssetsDependsOn>
</PropertyGroup>
```

Fixes #16065.


Backport of #16089

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@emaf emaf emaf approved these changes

@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner

+1 more reviewer

@chamons chamons chamons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug If an issue is a bug or a pull request a bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Two MacCatalyst RIDs can cause error : Unable to merge the file 'Contents/Resources/Assets.car'

5 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @emaf @chamons