Skip to content

[msbuild] Promote '_PartialAppManifest' to a public item group ('PartialAppManifest'). Fixes #10646.#12417

Merged
rolfbjarne merged 5 commits intodotnet:mainfrom
rolfbjarne:issue-10646
Aug 12, 2021
Merged

[msbuild] Promote '_PartialAppManifest' to a public item group ('PartialAppManifest'). Fixes #10646.#12417
rolfbjarne merged 5 commits intodotnet:mainfrom
rolfbjarne:issue-10646

Conversation

@rolfbjarne
Copy link
Member

  • A couple of other changes to make sure we never overwrite the
    PartialAppManifest item group (as opposed to adding to it).
  • Add tests.

Fixes #10646.

@rolfbjarne rolfbjarne requested a review from emaf as a code owner August 12, 2021 05:34
@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Aug 12, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 127 tests passed 🎉

Pipeline on Agent XAMBOT-1104.BigSur'
Merge d62d857 into 1c937ac

@rolfbjarne rolfbjarne merged commit aee4cc0 into dotnet:main Aug 12, 2021
@rolfbjarne rolfbjarne deleted the issue-10646 branch August 12, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET 6: add support for specifying additional partial Info.plists that are to be merged into the final Info.plist

4 participants