[src] Don't generate a reference assembly for both the 32-bit and 64-bit variant of Xamarin.WatchOS.dll.#10136
Merged
rolfbjarne merged 2 commits intodotnet:mainfrom Nov 23, 2020
Merged
Conversation
…bit variant of Xamarin.WatchOS.dll.
We only need one version, and in any case the code would write both the same
file, causing corruption and random build problems later.
Fixes this problem while building .NET packages:
/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/dotnet/package/common.csproj(75,5): error : Classification matches no files: Xamarin.WatchOS.dll [/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/dotnet/package/Microsoft.watchOS.Ref/package.csproj]
make[1]: *** [nupkgs/Microsoft.watchOS.Ref.7.1.100-ci.main.35+sha.a4a1fea86.nupkg] Error 1
dalexsoto
approved these changes
Nov 23, 2020
Contributor
|
Build failure |
spouliot
approved these changes
Nov 23, 2020
…ference assembly.
Contributor
|
Build success |
dalexsoto
pushed a commit
to dalexsoto/xamarin-macios
that referenced
this pull request
Nov 23, 2020
…bit variant of Xamarin.WatchOS.dll. (dotnet#10136) * [src] Don't generate a reference assembly for both the 32-bit and 64-bit variant of Xamarin.WatchOS.dll. We only need one version, and in any case the code would write both the same file, causing corruption and random build problems later. Fixes this problem while building .NET packages: /Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/dotnet/package/common.csproj(75,5): error : Classification matches no files: Xamarin.WatchOS.dll [/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/dotnet/package/Microsoft.watchOS.Ref/package.csproj] make[1]: *** [nupkgs/Microsoft.watchOS.Ref.7.1.100-ci.main.35+sha.a4a1fea86.nupkg] Error 1 * Fix the make rule too so that it doesn't claim it can generate the reference assembly.
dalexsoto
pushed a commit
to dalexsoto/xamarin-macios
that referenced
this pull request
Dec 3, 2020
…bit variant of Xamarin.WatchOS.dll. (dotnet#10136) * [src] Don't generate a reference assembly for both the 32-bit and 64-bit variant of Xamarin.WatchOS.dll. We only need one version, and in any case the code would write both the same file, causing corruption and random build problems later. Fixes this problem while building .NET packages: /Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/dotnet/package/common.csproj(75,5): error : Classification matches no files: Xamarin.WatchOS.dll [/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/dotnet/package/Microsoft.watchOS.Ref/package.csproj] make[1]: *** [nupkgs/Microsoft.watchOS.Ref.7.1.100-ci.main.35+sha.a4a1fea86.nupkg] Error 1 * Fix the make rule too so that it doesn't claim it can generate the reference assembly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only need one version, and in any case the code would write both the same
file, causing corruption and random build problems later.
Fixes this problem while building .NET packages: