[main][watchOS] Add x86_64 simulator support by dalexsoto · Pull Request #10059 · dotnet/macios

dalexsoto · 2020-11-05T22:26:41Z

Bumps mono binaries to include x86_64 watchOS support
Build runtime/registrar x86_64 slices
Produce a 64 bit version of Xamarin.WatchOS.dll
Allow building x86_64 for watch simulators in mtouch
Let xharness know about x86_64

New commits in mono/mono:

mono/mono@ac596375c76 Add support for OP_FCONV_TO_I to mini-arm64.c. ([release/9.0.1xx-preview4] Update dependencies from dotnet/installer #20548)
mono/mono@392fe5b87b2 [2020-02][watchOS] Add simwatch64 support ([release/8.0.1xx-xcode15.1] Update dependencies from dotnet/installer #20552)
mono/mono@a22ed3f094e Fix potential crash for Encoder.Convert ([net9.0] Update dependencies from dotnet/installer #20522)
mono/mono@970783731fc Bump to F# 5.0 ([bgen] Generate xml documentation for generated enums. #20511)
mono/mono@32ab5066f72 Bump msbuild to fix a build issue
mono/mono@93a7fe77e8e Ensure special static slots respect alignment. ([msbuild] Set the working directory before executing 'dotnet build' in the ComputeRemoteGeneratorProperties task. #20506)
mono/mono@3db5b358413 [debugger] Switch to GC Unsafe in signal handler callbacks (Unexpected error (MT0000) in release mode xamarin forms in platform macos #20495)
mono/mono@af315f44c40 [2020-02][corlib] ThreadAbortException protection for ArraySortHelper ([GameplayKit] Remove the bindings for GKHybridStrategist. #20468)

Diff: https://github.com/mono/mono/compare/ca11fb0fd819a1e32565b0d626506f66fb9fd272..ac596375c762c6b8dbe3c802f0ce626004eab51c

* Bumps mono binaries to include x86_64 watchOS support * Build runtime/registrar x86_64 slices * Produce a 64 bit version of Xamarin.WatchOS.dll * Allow building x86_64 for watch simulators in mtouch * Let xharness know about x86_64 New commits in mono/mono: * mono/mono@392fe5b87b2 [2020-02][watchOS] Add simwatch64 support (dotnet#20552) * mono/mono@a22ed3f094e Fix potential crash for Encoder.Convert (dotnet#20522) * mono/mono@970783731fc Bump to F# 5.0 (dotnet#20511) * mono/mono@32ab5066f72 Bump msbuild to fix a build issue * mono/mono@93a7fe77e8e Ensure special static slots respect alignment. (dotnet#20506) * mono/mono@3db5b358413 [debugger] Switch to GC Unsafe in signal handler callbacks (dotnet#20495) * mono/mono@af315f44c40 [2020-02][corlib] ThreadAbortException protection for ArraySortHelper (dotnet#20468) Diff: https://github.com/mono/mono/compare/ca11fb0fd819a1e32565b0d626506f66fb9fd272..392fe5b87b2ed710202a84588b0f93ad43728cad

monojenkins · 2020-11-06T00:23:33Z

Build failure
❌ Build failed or was aborted

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

Test run in progress: BuildQueued: 123, Built: 1, Running: 1, Succeeded: 1, Ignored: 1190

Looks like the bot ran out of space...

dalexsoto · 2020-11-06T00:58:40Z

build

monojenkins · 2020-11-06T05:47:46Z

Build failure

!!! Couldn't read commit file !!!

monojenkins · 2020-11-06T07:25:15Z

Build failure
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

Test run in progress: BuildQueued: 123, Built: 1, Running: 1, Succeeded: 1, Ignored: 1190

rolfbjarne

This looks great! It also looks like mtouch didn't need many changes to support fat watch simulator apps!

monojenkins · 2020-11-06T09:20:34Z

Build failure
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

# Test run in progress: Building: 2, BuildQueued: 8, Built: 87, Succeeded: 2, Ignored: 1210, BuildFailure: 7

Failed tests

monotouch-test/watchOS 32-bits - simulator/Debug: BuildFailure
framework-test/watchOS 32-bits - simulator/Debug: BuildFailure
interdependent-binding-projects/watchOS 32-bits - simulator/Debug: BuildFailure
link all/watchOS 32-bits - simulator/Debug: BuildFailure
link all/watchOS 32-bits - simulator/Release: BuildFailure
link sdk/watchOS 32-bits - simulator/Debug: BuildFailure
link sdk/watchOS 32-bits - simulator/Release: BuildFailure

rolfbjarne · 2020-11-06T09:40:01Z

Native linking failed, undefined Objective-C class: FrameworkTest. The symbol 'OBJC_CLASS$_FrameworkTest' could not be found in any of the libraries or frameworks linked with your application.

This is because you have to add a x86_64 build of our test libraries in tests/test-libraries

New commits in mono/mono: * mono/mono@ac596375c76 Add support for OP_FCONV_TO_I to mini-arm64.c. (dotnet#20548) Diff: https://github.com/mono/mono/compare/392fe5b87b2ed710202a84588b0f93ad43728cad..ac596375c762c6b8dbe3c802f0ce626004eab51c

monojenkins · 2020-11-06T14:56:09Z

Build failure
❌ Build failed or was aborted

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)

monojenkins · 2020-11-06T18:56:07Z

Build failure
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

# Test run in progress: Running: 1, Succeeded: 95, Failed: 1, Ignored: 1210, Crashed: 9

Failed tests

monotouch-test/iOS Unified 64-bits - simulator/Debug: Failed
monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Crashed
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Crashed
monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Crashed
[NUnit] Mono SystemNumericsTests/watchOS 32-bits - simulator/Debug: Crashed
[NUnit] Mono MonoRuntimeTests/watchOS 32-bits - simulator/Debug: Crashed
[xUnit] Mono SystemNumericsXunit/watchOS 32-bits - simulator/Debug: Crashed
[xUnit] Mono MicrosoftCSharpXunit/watchOS 32-bits - simulator/Debug: Crashed
[xUnit] Mono SystemCoreXunit Part 1/watchOS 32-bits - simulator/Debug: Crashed

monojenkins · 2020-11-10T19:59:51Z

Build failure
❌ Build failed or was aborted

✅ Provisioning succeeded
🔥 Build failed 🔥

monojenkins · 2020-11-10T20:26:05Z

Build failure
❌ Build failed or was aborted

✅ Provisioning succeeded
🔥 Build failed 🔥

monojenkins · 2020-11-11T03:45:29Z

Build failure
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

4 tests failed, 66 tests passed.

Failed tests

monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Crashed
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Crashed
monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Crashed

monojenkins · 2020-11-17T03:02:35Z

Build failure

!!! Couldn't read commit file !!!

rolfbjarne · 2020-11-17T06:25:43Z

build

monojenkins · 2020-11-17T12:18:49Z

Build failure
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

4 tests failed, 66 tests passed.

Failed tests

monotouch-test/watchOS 32-bits - simulator/Debug: Failed
monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Failed
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Failed
monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Failed

dalexsoto · 2020-11-20T00:34:35Z

build

monojenkins · 2020-11-20T03:40:15Z

Build success
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded

dalexsoto · 2020-11-20T03:48:49Z

Fake green aka gred 🤥

⚠️ Build test/test-libraries failed ⚠️

monojenkins · 2020-11-20T03:59:11Z

Build success
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded

dalexsoto · 2020-11-20T04:03:46Z

Fake green aka gred 🤥

⚠️ Build test/test-libraries failed ⚠️

rolfbjarne · 2020-11-20T07:08:14Z

build

rolfbjarne · 2020-11-20T07:09:03Z

@dalexsoto it seems that merging main disabled the watch simulator tests again, which is why the PR turned greenish.

…in a 64-bit watchOS simulator.

monojenkins · 2020-11-20T09:37:24Z

Build failure
❌ Build failed or was aborted

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)

monojenkins · 2020-11-20T09:40:13Z

Build failure
❌ Build failed or was aborted

✅ Provisioning succeeded

monojenkins · 2020-11-20T12:55:43Z

Build success
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded

* [watchOS] Add x86_64 simulator support * Bumps mono binaries to include x86_64 watchOS support * Build runtime/registrar x86_64 slices * Produce a 64 bit version of Xamarin.WatchOS.dll * Allow building x86_64 for watch simulators in mtouch * Let xharness know about x86_64 * [tests] Add x86_64 arch to test-libraries * Make dotnet package aware of x64 * [ObjCRuntime] Fix computing if we're calling a stret function or not in a 64-bit watchOS simulator. * [xharness] Re-enable some watchOS tests. Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> New commits in mono/mono: * mono/mono@ac596375c76 Add support for OP_FCONV_TO_I to mini-arm64.c. (dotnet#20548) * mono/mono@392fe5b87b2 [2020-02][watchOS] Add simwatch64 support (dotnet#20552) * mono/mono@a22ed3f094e Fix potential crash for Encoder.Convert (dotnet#20522) * mono/mono@970783731fc Bump to F# 5.0 (dotnet#20511) * mono/mono@32ab5066f72 Bump msbuild to fix a build issue * mono/mono@93a7fe77e8e Ensure special static slots respect alignment. (dotnet#20506) * mono/mono@3db5b358413 [debugger] Switch to GC Unsafe in signal handler callbacks (dotnet#20495) * mono/mono@af315f44c40 [2020-02][corlib] ThreadAbortException protection for ArraySortHelper (dotnet#20468) * mono/mono@ca11fb0fd81 [2020-02] Bump ikvm-fork to include mono/ikvm-fork#20 (dotnet#20452) Diff: https://github.com/mono/mono/compare/be2226b5a1c57df065efc4c1cf008d581e5cec7d..ac596375c762c6b8dbe3c802f0ce626004eab51c

[Xcode12.3] [watchOS] Add x86_64 simulator support (#10059)

dalexsoto added the note-highlight Worth calling out specifically in release notes label Nov 5, 2020

dalexsoto added this to the Future milestone Nov 5, 2020

dalexsoto requested review from chamons, mandel-macaque, rolfbjarne and spouliot November 5, 2020 22:26

dalexsoto linked an issue Nov 5, 2020 that may be closed by this pull request

[xcode12.2] watchOS apps don't deploy to watchOS 7.1 simulators #9949

Closed

dalexsoto changed the title ~~[watchOS] Add x86_64 simulator support~~ [main][watchOS] Add x86_64 simulator support Nov 5, 2020

spouliot approved these changes Nov 5, 2020

View reviewed changes

mandel-macaque approved these changes Nov 5, 2020

View reviewed changes

rolfbjarne approved these changes Nov 6, 2020

View reviewed changes

dalexsoto added 2 commits November 6, 2020 08:08

[tests] Add x86_64 arch to test-libraries

b5a6893

[mono] Bump mono to match android

08c7be7

New commits in mono/mono: * mono/mono@ac596375c76 Add support for OP_FCONV_TO_I to mini-arm64.c. (dotnet#20548) Diff: https://github.com/mono/mono/compare/392fe5b87b2ed710202a84588b0f93ad43728cad..ac596375c762c6b8dbe3c802f0ce626004eab51c

jonpryor mentioned this pull request Nov 6, 2020

Bump to mono/mono/2020-02@ac596375 dotnet/android#5273

Merged

tj-devel709 approved these changes Nov 6, 2020

View reviewed changes

spouliot mentioned this pull request Nov 9, 2020

[mono] Bump mono to match android #10069

Merged

Merge remote-tracking branch 'xamarin/main' into main-watchsim64

e4c0460

Merge remote-tracking branch 'xamarin/main' into main-watchsim64

7bed8b3

Make dotnet package aware of x64

d7ee80d

stephen-hawley approved these changes Nov 16, 2020

View reviewed changes

Merge remote-tracking branch 'xamarin/main' into main-watchsim64

6cf56e9

Merge remote-tracking branch 'xamarin/main' into main-watchsim64

d8e2be4

rolfbjarne added 2 commits November 20, 2020 10:19

[ObjCRuntime] Fix computing if we're calling a stret function or not …

f32d336

…in a 64-bit watchOS simulator.

[xharness] Re-enable some watchOS tests.

e0a1e74

dalexsoto merged commit 72c7b1f into dotnet:main Nov 20, 2020

dalexsoto deleted the main-watchsim64 branch November 20, 2020 14:44

dalexsoto mentioned this pull request Dec 3, 2020

[Xcode12.3] [watchOS] Add x86_64 simulator support (#10059) #10196

Merged

dalexsoto added a commit that referenced this pull request Dec 8, 2020

Merge pull request #10196 from dalexsoto/xcode12.3-watchsim64

8830d0c

[Xcode12.3] [watchOS] Add x86_64 simulator support (#10059)

Conversation

dalexsoto commented Nov 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

monojenkins commented Nov 6, 2020 • edited by dalexsoto Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test results

Test run in progress: BuildQueued: 123, Built: 1, Running: 1, Succeeded: 1, Ignored: 1190

Uh oh!

dalexsoto commented Nov 6, 2020

Uh oh!

monojenkins commented Nov 6, 2020

Uh oh!

monojenkins commented Nov 6, 2020

Test results

Test run in progress: BuildQueued: 123, Built: 1, Running: 1, Succeeded: 1, Ignored: 1190

Uh oh!

rolfbjarne left a comment

Choose a reason for hiding this comment

Uh oh!

monojenkins commented Nov 6, 2020

Test results

Failed tests

Uh oh!

rolfbjarne commented Nov 6, 2020

Uh oh!

monojenkins commented Nov 6, 2020

Uh oh!

monojenkins commented Nov 6, 2020

Test results

Failed tests

Uh oh!

monojenkins commented Nov 10, 2020

Uh oh!

monojenkins commented Nov 10, 2020

Uh oh!

monojenkins commented Nov 11, 2020

Test results

Failed tests

Uh oh!

monojenkins commented Nov 17, 2020

Uh oh!

rolfbjarne commented Nov 17, 2020

Uh oh!

monojenkins commented Nov 17, 2020

Test results

Failed tests

Uh oh!

dalexsoto commented Nov 20, 2020

Uh oh!

monojenkins commented Nov 20, 2020

Uh oh!

dalexsoto commented Nov 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

monojenkins commented Nov 20, 2020

Uh oh!

dalexsoto commented Nov 20, 2020

Uh oh!

rolfbjarne commented Nov 20, 2020

Uh oh!

rolfbjarne commented Nov 20, 2020

Uh oh!

monojenkins commented Nov 20, 2020

Uh oh!

monojenkins commented Nov 20, 2020

Uh oh!

monojenkins commented Nov 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dalexsoto commented Nov 5, 2020 •

edited

Loading

monojenkins commented Nov 6, 2020 •

edited by dalexsoto

Loading

dalexsoto commented Nov 20, 2020 •

edited

Loading