Fix analyzer test generation for non-public Main#3151
Merged
sbomer merged 1 commit intodotnet:mainfrom Dec 6, 2022
Merged
Conversation
tlakollo
reviewed
Dec 6, 2022
|
|
||
| [Fact] | ||
| public Task BaseProvidesInterfaceMethod () | ||
| public Task VarianceBasic () |
Contributor
There was a problem hiding this comment.
Do we know why this happens? I do see that the VarianceBasic had a private Main method and is fine that we now have the Fact being generated. But why the BaseProvidesInterfaceMethod disappeared? And why there are no other tests? inside the Inheritance.Interfaces.StaticInterfaceMethods folder I see 10 files.
Member
Author
There was a problem hiding this comment.
The BaseProvidesInterfaceMethods and other tests besides VarianceBasic already exist in the non-generated StaticInterfaceMethods.cs. The generated BaseProvidesInterfaceMethod was left over even though the source generator is no longer generating it - and it wasn't being overwritten because it thought all of the testcases were already present (it doesn't generate a file with no facts in that case).
tlakollo
approved these changes
Dec 6, 2022
tlakollo
pushed a commit
to tlakollo/linker
that referenced
this pull request
Dec 20, 2022
The ILLink analyzer testcase generator was generating extra testcases in dotnet/runtime, compared to linker. It turned out that in dotnet/linker, testcases with non-public Main methods were not getting generated, because the generator was getting a reference assembly for Mono.Linker.Tests.Cases.dll (which doesn't contain the non-public entry point), whereas dotnet/runtime has ref assembly generation turned off (so the analyzer was correctly discovering testcases based on the implementation assembly). This fixes the issue by turning off ref assembly generation for all projects except those specifically designed to be ref assemblies. The CompilerGeneratedCodeSubstitutions is disabled because it is not supported by the analyzer. Commit migrated from dotnet@c9ba21d
tlakollo
pushed a commit
to tlakollo/runtime
that referenced
this pull request
Dec 22, 2022
The ILLink analyzer testcase generator was generating extra testcases in dotnet/runtime, compared to linker. It turned out that in dotnet/linker, testcases with non-public Main methods were not getting generated, because the generator was getting a reference assembly for Mono.Linker.Tests.Cases.dll (which doesn't contain the non-public entry point), whereas dotnet/runtime has ref assembly generation turned off (so the analyzer was correctly discovering testcases based on the implementation assembly). This fixes the issue by turning off ref assembly generation for all projects except those specifically designed to be ref assemblies. The CompilerGeneratedCodeSubstitutions is disabled because it is not supported by the analyzer. Commit migrated from dotnet/linker@c9ba21d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dotnet/runtime#79011 @tlakollo discovered that the ILLink analyzer testcase generator was generating extra testcases in dotnet/runtime, compared to linker. It turned out that in dotnet/linker, testcases with non-public Main methods were not getting generated, because the generator was getting a reference assembly for Mono.Linker.Tests.Cases.dll (which doesn't contain the non-public entry point), whereas dotnet/runtime has ref assembly generation turned off (so the analyzer was correctly discovering testcases based on the implementation assembly).
This fixes the issue by turning off ref assembly generation for all projects except those specifically designed to be ref assemblies.
The CompilerGeneratedCodeSubstitutions is disabled as in dotnet/runtime#79011.