Use ContainingType instead of ContainingSymbol in GetReferenceKind#3107
Merged
jtschuster merged 2 commits intodotnet:mainfrom Nov 10, 2022
Merged
Use ContainingType instead of ContainingSymbol in GetReferenceKind#3107jtschuster merged 2 commits intodotnet:mainfrom
jtschuster merged 2 commits intodotnet:mainfrom
Conversation
sbomer
reviewed
Nov 10, 2022
Member
There was a problem hiding this comment.
Thanks! The fix looks ok to me but we should at least have a testcase.
Just to make sure you saw it, the original issue mentioned it was caused by this line: https://github.com/dotnet/aspnetcore/blob/45a75ad446294116024e640bb7efabfcfe2ac210/src/Components/WebAssembly/WebAssembly/src/HotReload/HotReloadAgent.cs#L132 - in case that helps trying to get a repro/testcase.
vitek-karas
approved these changes
Nov 10, 2022
sbomer
approved these changes
Nov 10, 2022
tlakollo
pushed a commit
to tlakollo/linker
that referenced
this pull request
Dec 20, 2022
tlakollo
pushed a commit
to tlakollo/runtime
that referenced
this pull request
Dec 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expecting IMethodSymbol.ContainingSymbol to be an ITypeSymbol is causing a type cast exception for local methods that require dataflow analysis (#3106), and it makes more sense to use ContainingType. I haven't been able to repro the issue (I've had problems building asp.net), but it seems pretty clear this is the fix.