Add another local function branch removal test#2931
Merged
sbomer merged 3 commits intodotnet:mainfrom Aug 1, 2022
Merged
Conversation
This is like the existing test, but additionally shows a visible difference in the warning behavior.
Member
Author
|
Never mind, I thought I had a case that showed different warning behavior but I was doing something wrong locally. Please ignore. |
Member
Author
|
Ah, it's too sensitive to ordering. Putting it in its own test file gives the warning I expected. |
vitek-karas
approved these changes
Aug 1, 2022
test/Mono.Linker.Tests.Cases/DataFlow/CompilerGeneratedCodeInPreservedAssemblyWithWarning.cs
Show resolved
Hide resolved
- Add issue link
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
This is like the existing test, but additionally shows a visible difference in the warning behavior. When the warning is produced for generic arguments rather than dataflow, it will show up even if we don't do dataflow for the local function whose callsite was removed. When branch removal breaks the link between the local function and its user method, this can result in warning suppressions that don't take effect. We could use the desired warning behavior to decide what the fix needs to do (whether it should do compiler-generated owning method detection before vs after constant propagation for the method). Commit migrated from dotnet/linker@783014a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is like the existing test, but additionally shows a visible
difference in the warning behavior. When the warning is produced for
generic arguments rather than dataflow, it will show up even if we don't
do dataflow for the local function whose callsite was removed.
When branch removal breaks the link between the local function and
its user method, this can result in warning suppressions that don't
take effect.
We could use the desired warning behavior to decide what the fix
needs to do (whether it should do compiler-generated owning method
detection before vs after constant propagation for the method).