Analyze nested functions in Roslyn analyzer#2892
Merged
sbomer merged 6 commits intodotnet:mainfrom Jul 15, 2022
Merged
Conversation
In the exception handling logic to avoid walking out to regions that are part of a different control flow graph. This fixes an analyzer crash discovered when running with these changes on dotnet/runtime.
vitek-karas
approved these changes
Jul 14, 2022
| var cfg = method.ControlFlowGraph; | ||
| var lValueFlowCaptures = LValueFlowCapturesProvider.CreateLValueFlowCaptures (cfg); | ||
| var visitor = GetVisitor (method.Method, cfg, lValueFlowCaptures, interproceduralState); | ||
| Fixpoint (new ControlFlowGraphProxy (cfg), Lattice, visitor); |
Member
There was a problem hiding this comment.
Not for this PR - in theory we should be able to use the solver similar to Fixpoint to drive the inter-method analysis as well instead of rolling out a private simple version here.
Adjust indentation
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
This is the Roslyn analyzer counterpart to dotnet/linker@bc46e44. It adds detection of captured locals, and conservatively analyzes them with all values that it encounters in the method. The analyzer makes no attempt to warn on reflection access to compiler-generated fields, because the compilation strategy for these is not known by the analyzer. Unlike the linker, this doesn't do conservative analysis for hoisted locals in state machine methods. The analyzer already understands control flow within state machines the same way it does for normal methods, so we just continue using that behavior here. We could consider improving the linker's analysis to match, but it would require a deeper understanding of the state machine methods. Commit migrated from dotnet/linker@d27ff61
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the Roslyn analyzer counterpart to #2842.
It adds detection of captured locals, and conservatively analyzes them with all values that it encounters in the method.
The analyzer makes no attempt to warn on reflection access to compiler-generated fields, because the compilation strategy for these is not known by the analyzer.
Unlike the linker, this doesn't do conservative analysis for hoisted locals in state machine methods. The analyzer already understands control flow within state machines the same way it does for normal methods, so we just continue using that behavior here. We could consider improving the linker's analysis to match, but it would require a deeper understanding of the state machine methods.