Refactorings to help with linker->AOT integration#2883
Merged
vitek-karas merged 4 commits intodotnet:mainfrom Jul 9, 2022
Merged
Refactorings to help with linker->AOT integration#2883vitek-karas merged 4 commits intodotnet:mainfrom
vitek-karas merged 4 commits intodotnet:mainfrom
Conversation
tlakollo
approved these changes
Jul 7, 2022
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Move CompilerGenerated* classes to the DataFlow directory. They sort of belong there anyway and they should be "shared" with AOT (and the entire DataFlow directory is "Shared"). Change how interprocedural state method tracking is initiated. For the parent method we track the "body", for everything else we add the method itself (and get the body inside the tracking). In AOT, getting a body of a method is more complicated and so having it in one place helps with factoring. Linker doesn't care either way so I made it symetric with AOT. InterproceduralStateLattice in AOT has state (IL Provider) so it has to be instantiated for each scanner separately. Made a symetric change in linker. Adds a test for nested local functions and data flow. Commit migrated from dotnet/linker@81c90bb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move CompilerGenerated* classes to the DataFlow directory. They sort of belong there anyway and they should be "shared" with AOT (and the entire DataFlow directory is "Shared").
Change how interprocedural state method tracking is initiated. For the parent method we track the "body", for everything else we add the method itself (and get the body inside the tracking). In AOT, getting a body of a method is more complicated and so having it in one place helps with factoring. Linker doesn't care either way so I made it symetric with AOT.
InterproceduralStateLattice in AOT has state (IL Provider) so it has to be instantiated for each scanner separately. Made a symetric change in linker.
Adds a test for nested local functions and data flow.