Use net6.0 reference assemblies in analyzer tests #2121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version is currently hardcoded in TestCaseUtils.cs, but since these are reference assemblies, as long as the surface area isn't predicted to change, we can update as necessary.
tlakollo
reviewed
Jun 30, 2021
| public static readonly ReferenceAssemblies Net6PreviewAssemblies = | ||
| new ReferenceAssemblies ( | ||
| "net6.0", | ||
| new PackageIdentity ("Microsoft.NETCore.App.Ref", "6.0.0-preview.5.21224.4"), |
Contributor
There was a problem hiding this comment.
I'm not very familiar with ReferenceAssemblies creation but I assume the package identity version doesn't need to be maintained unless we actually need newer ReferenceAssemblies, we just took one version and rely on it even if the linker global.json changes, right?
Member
Author
There was a problem hiding this comment.
Yup, that's the idea. Unless there's a breaking change in the reference assemblies, we shouldn't care which exact version we use.
tlakollo
approved these changes
Jun 30, 2021
agocke
added a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
The version is currently hardcoded in TestCaseUtils.cs, but since these are reference assemblies, as long as the surface area isn't predicted to change, we can update as necessary. Commit migrated from dotnet/linker@f549b4e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version is currently hardcoded in TestCaseUtils.cs, but since
these are reference assemblies, as long as the surface area isn't
predicted to change, we can update as necessary.