Revert "Remove custom marking of nested types for event sources (#2032)" #2063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbomer
approved these changes
May 27, 2021
Member
sbomer
left a comment
There was a problem hiding this comment.
I don't have all of the context on the EventSource plan, but the revert LGTM.
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…et/linker#2032)" (dotnet/linker#2063) We still cannot take out the special handling for EventSource This reverts commit dotnet/linker@2cf3082. Commit migrated from dotnet/linker@50901f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still cannot take out the special handling for EventSource due to test failures in runtime repo. Will reopen #1949
This reverts commit 2cf3082.