Fix a problem where generating an empty FS assembly element roots the whole assembly#2051
Merged
vitek-karas merged 2 commits intodotnet:mainfrom May 24, 2021
Merged
Conversation
LakshanF
approved these changes
May 24, 2021
Contributor
LakshanF
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
… whole assembly (dotnet/linker#2051) Descriptors have the behavior that specifying just the assembly element without any children will root the entire assembly (and everything in it). The same applies to types (specifying just the type element will mark the entire type). With the new feature switches, we have to be careful to not generate an empty assembly element, otherwise we will accidentally root the entire corelib. Fixes the problem seen in #53144. Commit migrated from dotnet/linker@4d42726
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptors have the behavior that specifying just the assembly element without any children will root the entire assembly (and everything in it). The same applies to types (specifying just the type element will mark the entire type).
With the new feature switches, we have to be careful to not generate an empty assembly element, otherwise we will accidentally root the entire corelib.
Fixes the problem seen in dotnet/runtime#53144.