Merged
Conversation
sbomer
approved these changes
Mar 12, 2021
| <ProjectReference Condition="'$(UseCecilPackage)' != 'true'" Include="../../external/cecil/Mono.Cecil.csproj" PrivateAssets="All" /> | ||
| <ProjectReference Condition="'$(UseCecilPackage)' != 'true'" Include="../../external/cecil/Mono.Cecil.csproj" PrivateAssets="All"> | ||
| <!-- https://github.com/dotnet/sdk/issues/2280#issuecomment-392815466 --> | ||
| <SetTargetFramework>TargetFramework=netstandard2.0</SetTargetFramework> |
Member
There was a problem hiding this comment.
Why was this needed? (Or is it just to be safe?)
Member
Author
There was a problem hiding this comment.
For some reason it picked the net40 version... it's weird, but I just could not make it work otherwise.
Member
There was a problem hiding this comment.
Weird... 🤷♂️ Glad you figured it out. I didn't know about SetTargetFramework
| // Ensure that [Required] members are non-null | ||
| AssemblyPaths = new ITaskItem[0]; | ||
| RootAssemblyNames = new ITaskItem[0]; | ||
| ILLinkPath = Path.Combine (Path.GetDirectoryName (Assembly.GetExecutingAssembly ().Location), "illink.dll"); |
Member
There was a problem hiding this comment.
Curious what prompted this change
Member
Author
There was a problem hiding this comment.
The logic in the ILLink is basically MyPath/../../bin/net5.0/illink.dll. Which worked before by luck, since the folder in the artifacts where the test lives ends with bin/net5.0 as well. Now when the test is running on 6, the path ends with bin/net6.0.
But the product is still NET5.
marek-safar
approved these changes
Mar 13, 2021
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Commit migrated from dotnet/linker@70612c2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retarget all tests to run on .NET6. This will allow us to test some new APIs added into the framework for .NET 6.
The changes in MembersUsedViaReflection are due to change in the framework annotations - we're now marking less (but still enough).