Introduce test helpers and add DataFlowTypeExtensions#1890
Merged
marek-safar merged 4 commits intodotnet:mainfrom Mar 13, 2021
Merged
Introduce test helpers and add DataFlowTypeExtensions#1890marek-safar merged 4 commits intodotnet:mainfrom
marek-safar merged 4 commits intodotnet:mainfrom
Conversation
Several of the DataFlow tests use the `RequirePublicMethods` or similar methods to perform validation. These methods are always the same, so there no reason to duplicate them across tests.
marek-safar
approved these changes
Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several of the DataFlow tests use the
RequirePublicMethodsor similar methods to perform validation. These methods are always the same, so there no reason to duplicate them across tests.In the infra I added an exception that the Expectation assembly can contain non-attribute classes if they're in the Helper namespace.
It's cumbersome to add these helpers into the TestCases because each test case would have to add an explicit compilation attribute to include the source file in the test compilation.
If there are too many helpers, we might consider creating a new assembly for them instead.