Remove line ending config from editorconfig#1867
Merged
marek-safar merged 1 commit intodotnet:mainfrom Mar 4, 2021
Merged
Conversation
Git usually handles this correctly, and there are a number of problems with using LF locally on Windows.
vitek-karas
added a commit
to vitek-karas/linker
that referenced
this pull request
Mar 10, 2021
Change dotnet#1867 breaks running lint on Windows since it will reformat pretty much all the source files in the repo (change of newline). So I reverted that change 74fb9a9. Additionally latest lint writes formatDiagnosticLog.binlong next to the solution file when running with --verbosity diagnostic. There's no way to redirect or disable this - dotnet/format#1041. So this change disables --verbosity diagnostic for local runs of lint and adds it only to the CI (where the machine will clean the enlistment anyway).
vitek-karas
pushed a commit
to vitek-karas/linker
that referenced
this pull request
Mar 11, 2021
Git usually handles this correctly, and there are a number of problems with using LF locally on Windows.
agocke
added a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Git usually handles this correctly, and there are a number of problems with using LF locally on Windows. Commit migrated from dotnet/linker@74fb9a9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git usually handles this correctly, and there are a number of problems with using LF locally on Windows.
For instance, testing code fixes needs to have a baseline file, but the codefix APIs always insert
Environment.Newline when applying the refactoring, which makes it difficult to record the baseline in the file.