Skip to content

Follow up for #1609#1612

Merged
mateoatr merged 3 commits intodotnet:masterfrom
mateoatr:externalWarnings
Nov 9, 2020
Merged

Follow up for #1609#1612
mateoatr merged 3 commits intodotnet:masterfrom
mateoatr:externalWarnings

Conversation

@mateoatr
Copy link
Contributor

@mateoatr mateoatr commented Nov 6, 2020

No description provided.

@mateoatr mateoatr requested a review from marek-safar November 6, 2020 22:29
{
if (!(code >= 1000 && code <= 2000))
throw new ArgumentException ($"The provided code '{code}' does not fall into the error category, which is in the range of 1000 to 2000 (inclusive).");
throw new ArgumentOutOfRangeException ($"The provided code '{code}' does not fall into the error category, which is in the range of 1000 to 2000 (inclusive).");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pass parameter name as well to the ctors

@mateoatr mateoatr merged commit 1ce464d into dotnet:master Nov 9, 2020
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
* Follow up

* Add parameter to exception

* Fix formatting

Commit migrated from dotnet/linker@1ce464d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants