Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
9596132 to
f0627ac
Compare
|
The Windows tests are broken by dotnet/cecil@191f9fc |
|
Actually this is a known issue now: jbevain/cecil#694 |
|
@vitek-karas I reverted that change and still the same problem :-( |
|
That's because linker master still uses package reference to Mono.Cecil - so the fixes you picked up into the submodule don't apply. We will either have to wait for the fix to make it into cecil's master and eventually package, or switch fully to rely on the submodule. |
|
@vitek-karas yeah, I completely forgot about that |
* Build against Cecil submodule * Depend on official cecil version With this change, the nuspec of the ref assembly package will list cecil verision 0.11.2 as a dependency (instead of 5.0.0-rc*). This allows consumers of the ref package to use the publicly released cecil.
9cdc898 to
a7c8f6a
Compare
|
There's a formatting bug in the master - I just added a fix into this PR as it was faster... |
|
/cc @sbomer for when he gets back to take a quick look. |
The submodule update in dotnet#2156 incremented the cecil version, but we were still using 0.11.3 as the version in our package graph. See dotnet#1515 for more context on how this is set up. Fixes dotnet#2173
With this change, the nuspec of the ref assembly package will list cecil verision 0.11.2 as a dependency (instead of 5.0.0-rc*). This allows consumers of the ref package to use the publicly released cecil. Co-authored-by: Sven Boemer <sbomer@gmail.com> Co-authored-by: vitek-karas <vitek.karas@microsoft.com> Commit migrated from dotnet/linker@41078a0
* Bump cecil package version The submodule update in dotnet/linker#2156 incremented the cecil version, but we were still using 0.11.3 as the version in our package graph. See dotnet/linker#1515 for more context on how this is set up. Fixes dotnet/linker#2173 * Remove unnecessary cast Commit migrated from dotnet/linker@0cb9250
No description provided.