Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/linker
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: da244b7
Choose a base ref
...
head repository: dotnet/linker
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c9ba21d
Choose a head ref
  • 3 commits
  • 40 files changed
  • 2 contributors

Commits on Dec 5, 2022

  1. Update dependencies from https://github.com/dotnet/arcade build 20221…

    …129.2 (#3149)
    
    [main] Update dependencies from dotnet/arcade
    dotnet-maestro[bot] authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    4d2e2c9 View commit details
    Browse the repository at this point in the history
  2. Warn on reflection access to instance methods on RUC types (#3147)

    Fixes an analysis hole where reflecting on instance methods of RUC
    types produced no warnings. This isn't trim-compatible in case the
    methods are decorated with attributes with RUC constructors, or in
    case they are invoked on a null instance. We don't warn for RUC
    attributes on methods in RUC types, but instead prevent reflection
    access from creating these attributes by warning on the reflection
    access to methods (including instance methods).
    
    This leaves the attribute warnings for fields as-is - so instance
    fields will get attribute warnings unlike instance methods, because we
    don't warn on reflection access to instance fields in RUC types. This
    is currently inconsistent with the analyzer behavior, which doesn't warn
    for attributes in this case.
    sbomer authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    f3469ca View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Fix analyzer test generation for non-public Main (#3151)

    The ILLink analyzer testcase generator was generating extra
    testcases in dotnet/runtime, compared to linker. It turned out
    that in dotnet/linker, testcases with non-public Main methods
    were not getting generated, because the generator was getting a
    reference assembly for Mono.Linker.Tests.Cases.dll (which doesn't
    contain the non-public entry point), whereas dotnet/runtime has
    ref assembly generation turned off (so the analyzer was correctly
    discovering testcases based on the implementation assembly).
    
    This fixes the issue by turning off ref assembly generation for
    all projects except those specifically designed to be ref
    assemblies.
    
    The CompilerGeneratedCodeSubstitutions is disabled because it is
    not supported by the analyzer.
    sbomer authored Dec 6, 2022
    Configuration menu
    Copy the full SHA
    c9ba21d View commit details
    Browse the repository at this point in the history
Loading