source-build: stop overriding aspnetcore version#14938
source-build: stop overriding aspnetcore version#14938MichaelSimons merged 3 commits intodotnet:mainfrom
Conversation
…cts tarballs don't override it, and stop adding it to the PackageVersions.props in new Artifacts tarballs.
|
My understanding is the renamed property is temporary until the previous source-build artifacts have been updated to not include the extra property in the PackageVersions.props file. Given the rename affects the official source and is not very localized, what do you think about adding a call to |
I've implemented this. I had to move the |
MichaelSimons
left a comment
There was a problem hiding this comment.
LGTM - Thanks for refactoring to limit the impact of the temporary workaround. I have one minor comment.
|
@ayakael do you want to verify the patch works with the Alpine build? |
Sure, I'll do that right away. |
|
@tmds Testing against |
Rename MicrosoftAspNetCoreAppRuntimePackageVersion so existing Artifacts tarballs don't override it,
and stop adding it to the PackageVersions.props in new Artifacts tarballs.
Related to dotnet/source-build#3121.
cc @ayakael @MichaelSimons @crummel