Add more detailed source-build instructions to README#14038
Merged
Conversation
MichaelSimons
left a comment
Member
There was a problem hiding this comment.
I would suggested making this PR against 6.0.1xx and then it will automatically flow to all supported 6.x branches and main.
Member
|
@lbussell - Is this ready for review? I didn't spot the support policy so I wanted to check. TIA |
| @@ -42,6 +42,12 @@ This repo also contains code to help you build the entire .NET product end-to-en | |||
| This is currently only supported on Linux. | |||
Member
There was a problem hiding this comment.
This sentence feels like something that better belongs in the support section. Thoughts?
MichaelSimons
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes one part of dotnet/source-build#2602.
I will also submit a PR that removes the instructions from dotnet/source-build's readme and instead link to these more detailed instructions.