Skip to content

Conversation

@KevinRansom
Copy link
Contributor

  1. Parameterization of resources caused us to rebuild a few projects.
  2. The test that validated rebuild, didn't check all of the necessary files, and so missed the issue.

PR fixes the issue and the test.

@KevinRansom KevinRansom requested a review from brettfo July 24, 2020 07:10
@dsyme
Copy link
Contributor

dsyme commented Jul 24, 2020

Thank! I've confirmed this fixes things.

(On my somewhat slow machine I'm now seeing 37sec idempotent rebuild times for .\build -norestore)

@abelbraaksma
Copy link
Contributor

abelbraaksma commented Jul 24, 2020

It should be noted that build -build doesn't work, but this command is available according to build -help. (I think the option can just be removed)

@cartermp
Copy link
Contributor

@dsyme @KevinRansom if you open VisualFSharp.sln and set VisualFSharpFull as the startup project, ctrl+f5, launch the experimental VS hive, close it, then launch ctrl+f5 again, what happens?

@KevinRansom
Copy link
Contributor Author

@abelbraaksma , @cartermp . this addresses the specific issue of un-necessary rebuilds and the test that ensures it works. Please create seperate issues for unrelated build idiosyncracies.

Thanks

Kevin

@KevinRansom KevinRansom merged commit c042d5a into dotnet:master Jul 24, 2020
@cartermp
Copy link
Contributor

I'm not referring to any specific idiosynchracies. I'm just curious if this affects the inner loop when building VS tooling and using a VS hive to experiment with changes or debug. Rebuilds today weren't really a problem for me, but I also have a fairly fast machine so perhaps I just didn't notice.

@KevinRansom KevinRansom deleted the FixBuild branch August 19, 2020 20:21
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants