Clean up CE classification #9733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIHan
approved these changes
Jul 24, 2020
Contributor
TIHan
left a comment
There was a problem hiding this comment.
This is reasonable, though interesting that there are two different Items with the same range. I'm wondering why there were two in the first place. Would it be possible to only emit one of them? Don't think it's super necessary, but considering this is a heuristic it would be fair to investigate.
Contributor
Author
|
There may be a different fix in name resolution that distincts them down, though I this depends on what it would be used for. For the purposes of classification we want a specific resolution, but maybe another tooling scenario wants both. Feels a little bit like the whole |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9732
The problem is that for code like this:
asynchas two captured name resolutions:Item.ValueItem.CustomBuilderBoth are technically correct "views" of
async, but the latter is the correct classification type when you consider colorization. Because the cache we use de-duplicates based on range, andItemValuecomes first in the array of captured name resolutions,asyncwas classified as aValueand ultimately colored as plaintext.This prefers
Item.CustomBuilderfor the purposes of classification.