Fix handling of optional IDispatch, IUnknown method args#919
Merged
KevinRansom merged 3 commits intodotnet:masterfrom Feb 25, 2016
Merged
Fix handling of optional IDispatch, IUnknown method args#919KevinRansom merged 3 commits intodotnet:masterfrom
KevinRansom merged 3 commits intodotnet:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Why a function? Ti can ve replaced with the function body
Contributor
Author
There was a problem hiding this comment.
See #907 (comment) - extra problems occur when you put the code in a function. Wanted to make sure that was covered.
|
@latkin, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
@latkin, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Contributor
|
OK, looks good! |
Contributor
|
@dotnet-bot test this please |
KevinRansom
added a commit
that referenced
this pull request
Feb 25, 2016
Fix handling of optional IDispatch, IUnknown method args
Contributor
|
Thanks for taking care of this Lincoln, we miss you, and hope you are having a great time in your new Job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #907
Aligns F# compiler's treatment of these optional arguments with what C# and VB do.
For omitted
objoptional args:MarshalAs(IUnknown),MarshalAs(IDispatch), orMarshalAs(Interface), emit anulldefault valueIUnknownConstantAttributeemitUnknownWrapper(null)IDispatchConstantAttributeemitDispatchWrapper(null)Type.MissingSee relevant bits of the C# compiler and VB compiler.