Fixed exception that prevented creating a memory mapped file that sha… #8747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dow copies a file on-disk (dotnet#8238) * Fixed exception that prevented creating a memory mapped file that is shadow copied * Update bytes.fs
cartermp
approved these changes
Mar 18, 2020
Contributor
Author
|
Manually tested: |
KevinRansom
approved these changes
Mar 18, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
dotnet#8747) * Fixed exception that prevented creating a memory mapped file that shadow copies a file on-disk (dotnet#8238) * Fixed exception that prevented creating a memory mapped file that is shadow copied * Update bytes.fs * Added test for old fsharp core project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dow copies a file on-disk (#8238)
Fixed exception that prevented creating a memory mapped file that is shadow copied
Update bytes.fs
Fixes regression #8739 for dev16.5.
Seems we already had the fix in master, it just wasn't in 16.5.