Skip to content

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented Jan 22, 2020

This is some documentation and logic extraction related to #6810

There's no change in functionality here

@dsyme dsyme requested review from TIHan and cartermp January 22, 2020 17:14
@KevinRansom KevinRansom reopened this Jan 22, 2020
@dsyme dsyme merged commit 4a95e6a into dotnet:master Jan 22, 2020
@dsyme
Copy link
Contributor Author

dsyme commented Jan 22, 2020

@cartermp and @KevinRansom - thanks!

typeEquivAux EraseMeasures g g.uint64_ty ty

let rec isIntegerOrIntegerEnumTy g ty =
let rec IsIntegerOrIntegerEnumTy g ty =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is starting module values/functions with uppercase going to be considered the preferred code style in the compiler now? It's rather inconsistent with the core library.

nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* cleanup and alignment

* cleanup and alignment

* cleanup and alignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants