Reduce Number of isAppTy calls #8275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Jan 20, 2020
| // check if they are the same logical type (after removing all abbreviations) | ||
| tyconRefEq g tcr1 tcr2 | ||
| | _ -> false) | ||
| | _ -> false |
Contributor
There was a problem hiding this comment.
Nit: ValueNone should probably be preferred. Even though _ is used a lot in this codebase I think it's best if we only add new _ if we have 2 or more cases we don't care about
KevinRansom
approved these changes
Jan 21, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to compute both things in the inner loop