Allow length of zero for ByteMemory #8273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4004a87 to
24f2dd8
Compare
Contributor
|
O_O |
cartermp
approved these changes
Jan 19, 2020
Contributor
cartermp
left a comment
There was a problem hiding this comment.
Change is fine, but why 0 bytes?
Contributor
Author
|
This should also fix a regression that we have when trying to compile an ASP .NET project as there are IL resources that have a length of zero. |
brettfo
pushed a commit
to brettfo/fsharp
that referenced
this pull request
Jan 21, 2020
brettfo
added a commit
that referenced
this pull request
Jan 21, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.