Fix nuget and ref assemblies #8252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIHan
approved these changes
Jan 20, 2020
cartermp
approved these changes
Jan 20, 2020
Contributor
cartermp
left a comment
There was a problem hiding this comment.
I can't say I understand the MSBuild target that's written in there, but I understand the test and it is a good one.
brettfo
suggested changes
Jan 21, 2020
| <IsPackable>false</IsPackable> | ||
| <!-- Temporary fix some sdks, shipped internally with broken parameterization --> | ||
| <FSharpCoreImplicitPackageVersion Condition=""'$(FSharpCoreImplicitPackageVersion)' == '{{FSharpCoreShippedPackageVersion}}'"">4.7.0</FSharpCoreImplicitPackageVersion> |
Member
There was a problem hiding this comment.
This isn't going to do what you think. At this point you're inside a string in a .fs file; you need to have already computed the variable expansion {{FSharpCoreShippedPackageVersion}}.
brettfo
approved these changes
Jan 21, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Fix nuget and ref assemblies * Packaging fixes * tweaks * use substring rather than remove * Removed unused md * -1 means not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some black belt Msbuild Fu that fixes both. As well as a test case.