improve build telemetry #8239
Merged
improve build telemetry #8239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
approved these changes
Jan 16, 2020
7e1a035 to
3e4bc23
Compare
Member
|
Is there a test job we can look at to validate this works as expected? ie, have you tried forcing a failure or something? |
Member
Author
|
Good call, I just pushed a commit with a bad test that should catch on both Windows and Linux. If the build telemetry gets classified appropriately I'll walk back that commit. |
fb4da6c to
cda9234
Compare
cda9234 to
09366b8
Compare
Member
Author
|
Hijacked test resulted in the appropriate log lines and failure reasons: Linux/Mac: Windows: I'll revert the bad test and this can be merged as soon as it's green. |
09366b8 to
b5aa4a0
Compare
Member
|
Looks good, thanks Brett |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* add windows build telemetry * fix linux build telemetry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our build uses a custom script, this PR adds an explicit call to the Arcade function
Write-PipelineTelemetryErrorin the rootcatchblock. To handle the different stages of the build, two script-level variables are created,$BuildCategoryand$BuildMessage, that get updated so that in the case of a failure, the contents are relevant.