Using ArrayPool for AssocTable #8234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
reviewed
Jan 16, 2020
| let reductions = tables.reductions | ||
| let actionTable = new AssocTable(tables.actionTableElements, tables.actionTableRowOffsets) | ||
| let gotoTable = new AssocTable(tables.gotos, tables.sparseGotoTableRowOffsets) | ||
| let cacheSize = 7919 // the 1000'th prime |
Contributor
Author
There was a problem hiding this comment.
I have no idea :) - I just copied what was there.
cartermp
suggested changes
Jan 16, 2020
Contributor
cartermp
left a comment
There was a problem hiding this comment.
Style nits, one of which should impact debuggability I think.
we are allocating a large int array every time we want to parse anything.
Is there some trace data or benchmark that shows the impact of this?
Contributor
Author
|
@cartermp Added trace data |
Member
|
tagging myself so I can know to wait for this before releasing the next FCS. |
cartermp
approved these changes
Jan 17, 2020
4 tasks
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Using ArrayPool * Remove open * Changed some style nits * Clear arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses ArrayPool for AssocTable since we are allocating a large int array every time we want to parse anything.
