Rewrite UnusedDeclarationsAnalyzer logic#2914
Merged
KevinRansom merged 1 commit intodotnet:masterfrom Apr 26, 2017
Merged
Conversation
cartermp
approved these changes
Apr 25, 2017
Contributor
cartermp
left a comment
There was a problem hiding this comment.
LGTM modulo a stylistic nitpick
| let definitions = | ||
| symbolsUses | ||
| |> Array.filter (fun su -> | ||
| su.IsFromDefinition && |
Contributor
There was a problem hiding this comment.
nitpick: this boolean logic might be best tucked away in a function isValidForUnusedDeclaration to ease readability
KevinRansom
approved these changes
Apr 26, 2017
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2912
It contains a large chunk of commented code, I'd like to keep it for some time for debug purposes.