Conversation
|
@vasily-kirichenko I wonder if the issue is with the implementation itself at https://github.com/Microsoft/visualfsharp/blob/b3f6501ead8997c2b7f2e34fce75219d657aed2c/src/fsharp/vs/service.fs#L1394 ? Maybe it is at least worth putting a comment at the call site explaining the reason for |
|
I also completely fixes #2140 |
|
@smoothdeveloper other editors may want to get duplicated spans because I suspect (I've not checked, sorry) they are not strictly duplicated, but related to different symbols (for example, type itself and its primary ctor, I believe). I think it's absolutely necessary to |
* add glyph for declarations in Find All References result window * fixed: ColorizationService may return duplicated spans which caused FindReferencesService to crash * remove #nowarn "1182" * fixed: FindReferencesService does not work on external symbols

ColorizationServicereturned duplicated spans in some cases which causedFindReferencesServiceto crash somewhere in Roslyn code as it checks given spans for overlapping.It also added a glyph for a definition symbol in Find References results window: