Merged
Conversation
forki
reviewed
Jan 3, 2017
| interface IHelpContextService with | ||
| member this.Language = FSharpCommonConstants.FSharpLanguageName | ||
| member this.Product = FSharpCommonConstants.FSharpLanguageName | ||
| member this.Language = "fsharp" |
Contributor
There was a problem hiding this comment.
urgs. Where is the constant!?
Contributor
Author
There was a problem hiding this comment.
What would you name it? FSharpLanguageLongName?
KevinRansom
suggested changes
Jan 3, 2017
Contributor
KevinRansom
left a comment
There was a problem hiding this comment.
If you can update the "fsharp" to a commonconstant pls.
Contributor
Author
|
@KevinRansom done. |
KevinRansom
approved these changes
Jan 3, 2017
Contributor
|
Thank you for making this change. Kevin |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* fix Language and Product names in F1 help context * make "FSharp" a common constant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I broke it in 39dc63f