Various fixes for implement interface code fix#2120
Various fixes for implement interface code fix#2120KevinRansom merged 2 commits intodotnet:masterfrom
Conversation
…ame lines with let bindings
|
@dungpa works OK to me. What about removing "explicitly" word from the title? In F# you cannot implement an interface implicitly, so this word is just noise. |
|
The word 'explicitly' is there so that people coming from C# know exactly what to expect (C# editor provides 'Implement interface' and 'Implement interface explicitly' as two choices). I can remove it if anyone else also thinks it's redundant? |
|
I think we can remove the "explicitly" text since there is no implicit interface implementation in F# as @vasily-kirichenko mentioned. I think that having it there may confuse C# people, who may expect the ability to "just" implement an interface and wonder why they "have" to do it explicitly, and for people with no C# experience there's no issue in implicit v. explicit terminology. |
|
@vasily-kirichenko @cartermp Here it is #2126 |
* Insert closing brackets if they are missing * Find correct interface identifiers if object expressions are on the same lines with let bindings
Fixed these two small issues:
/cc @vasily-kirichenko @KevinRansom