Use Roslyn line numbers only in lexer cache#2090
Merged
KevinRansom merged 5 commits intodotnet:masterfrom Dec 31, 2016
Merged
Conversation
Contributor
Author
|
@dotnet-bot test this please |
Contributor
|
@vasily-kirichenko I think these may be related to the change. |
Contributor
Author
|
Fixed. |
Contributor
|
CI error is unrelated. Please merge asap |
forki
approved these changes
Dec 27, 2016
KevinRansom
approved these changes
Dec 28, 2016
Contributor
|
@vasily-kirichenko, would you resolve the conflicts please. Kevin |
Contributor
Author
|
this code was merged to #2102 and further refactored to Lexer class, so merging this PR would create conflicts and it's needed anymore anyway. |
Contributor
|
So the crash on last line is gone?
Am 28.12.2016 1:55 nachm. schrieb "Vasily Kirichenko" <
notifications@github.com>:
… Closed #2090 <#2090>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2090 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADgNH772k9egd_cllupjJohAjFoxFytks5rMlw8gaJpZM4LUvQz>
.
|
Contributor
Author
|
@forki Yes. |
# Conflicts: # vsintegration/src/FSharp.Editor/Common/CommonHelpers.fs
Contributor
Author
|
I'm reopening this as I closed #2102, which included "out of range" bug fix merged from this PR. |
KevinRansom
approved these changes
Dec 31, 2016
vasily-kirichenko
added a commit
to vasily-kirichenko/visualfsharp
that referenced
this pull request
Jan 4, 2017
Merged
KevinRansom
pushed a commit
that referenced
this pull request
Jan 6, 2017
* revert "Use Roslyn line numbers only in lexer cache" #2090 * fix OutOfRangeException in getCachedSourceLineData * fixed: lexer cache does not work at all * fix finding start line for relexing in getCachedSourceLineData
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* use Roslyn line numbers only in lexer cache * fix and refactor getSymbolAtPosition * fix after merge * fix out of range exn
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* revert "Use Roslyn line numbers only in lexer cache" dotnet#2090 * fix OutOfRangeException in getCachedSourceLineData * fixed: lexer cache does not work at all * fix finding start line for relexing in getCachedSourceLineData
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.