Skip to content

Add regression test: #15655, error codes 999 and 3217 are distinct#19480

Merged
T-Gro merged 2 commits intomainfrom
regression-test/issue15655
Mar 30, 2026
Merged

Add regression test: #15655, error codes 999 and 3217 are distinct#19480
T-Gro merged 2 commits intomainfrom
regression-test/issue15655

Conversation

@T-Gro
Copy link
Copy Markdown
Member

@T-Gro T-Gro commented Mar 24, 2026

Adds a regression test for #15655

Verifies that error code 3217 (notAFunctionButMaybeIndexerErrorCode) is distinct from error code 999 (packageManagerError) by triggering a NotAFunctionButIndexer diagnostic and confirming it reports code 3217.

Fixes #15655

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@T-Gro T-Gro requested a review from a team as a code owner March 24, 2026 10:55
@T-Gro T-Gro added NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes AI-Issue-Regression-PR PR adding regression test for a closed issue labels Mar 24, 2026
@T-Gro T-Gro requested a review from abonie March 24, 2026 10:55
@T-Gro T-Gro enabled auto-merge (squash) March 24, 2026 10:55
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@abonie
Copy link
Copy Markdown
Member

abonie commented Mar 25, 2026

For this one I think we should also add a test to check that the 999 gets triggered when appropriate? Didn't find one existing via a simple git grep "withErrorCode 999"

@T-Gro
Copy link
Copy Markdown
Member Author

T-Gro commented Mar 30, 2026

WE have those at

@T-Gro T-Gro merged commit 3ee2a3e into main Mar 30, 2026
48 checks passed
@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Mar 30, 2026
Copilot AI pushed a commit that referenced this pull request Mar 31, 2026
…#19480)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
Copilot AI pushed a commit that referenced this pull request Mar 31, 2026
…#19480)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
Copilot AI pushed a commit that referenced this pull request Mar 31, 2026
…#19480)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Issue-Regression-PR PR adding regression test for a closed issue NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Error number 3217 is reused for two errors

2 participants