Refresh the check of files when notified by F# analysis engine#1906
Merged
dsyme merged 4 commits intodotnet:masterfrom Dec 1, 2016
Merged
Refresh the check of files when notified by F# analysis engine#1906dsyme merged 4 commits intodotnet:masterfrom
dsyme merged 4 commits intodotnet:masterfrom
Conversation
dsyme
commented
Dec 1, 2016
|
|
||
| // The latest component model. This is used to retrieve IDiagnosticAnalyzerService. | ||
| // FSROSLYNTODO: Work out how to make this and the two tables below non-static. | ||
| static let mutable componentModelOpt : IComponentModel option = None |
Contributor
Author
There was a problem hiding this comment.
I'd like someone who understands MEF to go through and remove all these statics please. I don't think adding this one causes any additional problems that aren't already there, but it's still not right. I don't understand anything much about MEF.
Contributor
There was a problem hiding this comment.
I'll try to take a look once this PR is landed
Contributor
Author
|
Failures on AppVeyor/ The first two are now fixed, the other two I don't understand (unrelated to this checkin, but I just can't repro them, and they only seem to happen on AppVeyor) |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
…t#1906) This fixes a large chunk of dotnet#1808. I've tested it by hand. The build still doesn't react to files coming/going in DependencyFiles. I'll adjust the description in dotnet#1808 to make the cases distinct. Basically F# has an analysis engine which tells the UI when to do "foreground" rechecks of files because the checking state has changed. This reacts to those events. See https://fsharp.github.io/FSharp.Compiler.Service/queue.html for some info. When the UI gets the focus on a document, it should also notify the F# engine to start checking that document * fix tests * Fix bridge between backgronud builders * fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a large chunk of #1808. I've tested it by hand.
The build still doesn't react to files coming/going in DependencyFiles. I'll adjust the description in #1808 to make the cases distinct.
Basically F# has an analysis engine which tells the UI when to do "foreground" rechecks of files because the checking state has changed. This reacts to those events. See https://fsharp.github.io/FSharp.Compiler.Service/queue.html for some info.
When the UI gets the focus on a document, it should also notify the F# engine to start checking that document
Perhaps we could eventually let the Roslyn one drive the whole show.