Merged
Conversation
forki
approved these changes
Nov 24, 2016
| open Microsoft.CodeAnalysis.Editor.Implementation.CommentSelection | ||
| open Microsoft.CodeAnalysis.Host.Mef | ||
| open Microsoft.CodeAnalysis | ||
| open System.Composition |
Contributor
There was a problem hiding this comment.
are all these namespaces needed?
Contributor
Author
There was a problem hiding this comment.
no idea. errors are not highlighted in vs 2015 on this project. Ionide highlight almost everything as errors...
Contributor
|
Awesome @vasily-kirichenko @vladima. Will merge when green |
Contributor
|
Thank you @vasily-kirichenko and @vladima. I can't wait until we merge all the VFPT features too :) |
Contributor
Author
|
@dsyme I think coloring and "highlight current symbol in file" could be ported from VFPT quite easily. Re-implementing coloring could be a waste of time, there are many corner cases and we have a lot at tests for it. |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1785, thanks @vladima